Skip to content

feat: Add shutdown with timeout for metric exporter #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohammadVatandoost
Copy link
Contributor

#2574 Part 1: Adding shutdown_with_timeout for metric exporter

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner March 23, 2025 17:07
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.0%. Comparing base (37d7947) to head (132ee05).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/metric.rs 0.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/exporter.rs 0.0% 3 Missing ⚠️
...pentelemetry-sdk/src/metrics/in_memory_exporter.rs 0.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 50.0% 3 Missing ⚠️
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2854     +/-   ##
=======================================
- Coverage   81.1%   81.0%   -0.1%     
=======================================
  Files        124     125      +1     
  Lines      23927   23945     +18     
=======================================
+ Hits       19410   19413      +3     
- Misses      4517    4532     +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit af3a33e into open-telemetry:main Apr 1, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants