Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Anton Grübel as approver #2863

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

cijothomas
Copy link
Member

Anton has been helping with both main repo and the contrib repo for a while, and has accepted to volunteer time as an Approver.

Requirements from Otel guide has been met:
https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#requirements-2

@cijothomas cijothomas requested a review from a team as a code owner March 25, 2025 18:28
@cijothomas
Copy link
Member Author

All @open-telemetry/rust-maintainers has to approve (or don't object). Will leave open for 3-5 days for everyone to get a chance to comment.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1%. Comparing base (62e43c5) to head (74c689a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2863   +/-   ##
=====================================
  Coverage   81.1%   81.1%           
=====================================
  Files        124     124           
  Lines      23927   23927           
=====================================
+ Hits       19406   19410    +4     
+ Misses      4521    4517    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay 🍻

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cijothomas cijothomas merged commit 303803e into open-telemetry:main Mar 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants