fix: timeout being ignored in MeterProvider shutdown_with_timeout

[partg952]

Fixes #2574

Changes

Passed down the ignored timeout argument in shutdown_with_timeout in MeterProvider

When calling the shutdown_with_timeout in MeterProvider the timeout was being ignored and not being passed down the incoming inner function calls
This PR fixes that by calling shutdown_with_timeout at each level and passing timeout along with it.

Merge requirement checklist

• CONTRIBUTING guidelines followed
• Unit tests added/updated (if applicable)
• Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
• Changes in public API reviewed (if applicable)

[scottgerring]

Hey @partg952 , thanks for opening the PR!
I think you need to plumb the timeout further still; for instance, for PeriodicReader the timeout is discarded:

opentelemetry-rust/opentelemetry-sdk/src/metrics/periodic_reader.rs

Lines 495 to 497 in 146376f

	fn shutdown_with_timeout(&self, _timeout: Duration) -> OTelSdkResult {
	self.inner.shutdown()
	}

and a 5 second duration is used instead:

opentelemetry-rust/opentelemetry-sdk/src/metrics/periodic_reader.rs

Lines 593 to 595 in 146376f

	fn shutdown(&self) -> OTelSdkResult {
	self.shutdown_with_timeout(Duration::from_secs(5))
	}

(ManualReader is fine as is).

I reckon with that fixed, we'd also want a changelog entry in opentelemetry-sdk, because the observed behaviour of the shutdown will change - we'll honour the API!

Could you also add a regression test that verifies the timeout is passed through?

[scottgerring]

left a comment above with some suggestions!

[partg952]

Hey @scottgerring ,Thanks for taking a look , I will definitely edit it further and then add the regression test for it.

Thanks!

[partg952]

Hey @partg952 , thanks for opening the PR! I think you need to plumb the timeout further still; for instance, for PeriodicReader the timeout is discarded:

opentelemetry-rust/opentelemetry-sdk/src/metrics/periodic_reader.rs

Lines 495 to 497 in 146376f

	fn shutdown_with_timeout(&self, _timeout: Duration) -> OTelSdkResult {
	self.inner.shutdown()
	}

and a 5 second duration is used instead:

opentelemetry-rust/opentelemetry-sdk/src/metrics/periodic_reader.rs

Lines 593 to 595 in 146376f

	fn shutdown(&self) -> OTelSdkResult {
	self.shutdown_with_timeout(Duration::from_secs(5))
	}

(ManualReader is fine as is).

I reckon with that fixed, we'd also want a changelog entry in opentelemetry-sdk, because the observed behaviour of the shutdown will change - we'll honour the API!

Could you also add a regression test that verifies the timeout is passed through?

Hey @scottgerring , I have a little unclarity here, in periodic reeader, the shutdown with timeout is calling inner.shutdown normally without respecting the timeout , so do you want me to implement the whole functionality or just pass it down through the consequent function calls?