Commit dc8fcfb
fix: clarify description of LoggerConfig.trace_based (#4930)
Minor clarification. The reader of the current description may think
that if `trace_based = true` then log records not associated with a
trace should not be recorded (which is not true).
The proposed change is more precise and follows other parts of the
specification that use normative language such as
https://github.com/open-telemetry/opentelemetry-specification/blob/e4ad687a9e89abf9d59ee394ee10977d041b71ba/specification/logs/sdk.md?plain=1#L213-L217
https://github.com/open-telemetry/opentelemetry-specification/blob/e4ad687a9e89abf9d59ee394ee10977d041b71ba/specification/logs/sdk.md?plain=1#L249-L252
https://github.com/open-telemetry/opentelemetry-specification/blob/e4ad687a9e89abf9d59ee394ee10977d041b71ba/specification/logs/sdk.md?plain=1#L264-L266
Moreover, define the behavior when `trace_based = false` using normative
language.
---------
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>1 parent bafa9e2 commit dc8fcfb
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
213 | 216 | | |
214 | 217 | | |
215 | 218 | | |
| |||
0 commit comments