Clarify SDK behavior for Instrument Advisory Parameter #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Jan 28, 2025
trask
reviewed
Jan 28, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
dashpole
reviewed
Jan 28, 2025
lmolkova
approved these changes
Feb 4, 2025
carlosalberto
approved these changes
Feb 18, 2025
reyang
reviewed
Feb 18, 2025
jack-berg
reviewed
Feb 18, 2025
trask
reviewed
Feb 24, 2025
jack-berg
reviewed
Feb 25, 2025
jack-berg
reviewed
Feb 25, 2025
trask
reviewed
Feb 27, 2025
jack-berg
reviewed
Feb 27, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jmacd
approved these changes
Mar 12, 2025
trask
approved these changes
Mar 12, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
|
Maybe take a last look @jack-berg ? |
jack-berg
approved these changes
Mar 14, 2025
|
@carlosalberto could you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Fixes #4317
Changes
Mostly editorial, to specify SDK behavior for Advisory Parameters, explicitly calling out that SDK MUST give precedence to View config over InstrumentAdvisory. I believe this is already the intention, but was less specified. Though some wordings exist in the View spec about attribute-keys, no mention about Histogram buckets..
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary