Yamlify the spec compliance matrix#4631
Conversation
|
Added benefits:
|
|
Is it an eventual goal to move the language implementation specific yaml file to the implementation repo? |
yes, I like that idea, this is just a step in the direction |
- Update pull request template to point to spec-compliance-matrix directory - Add contributing guide section explaining how to update compliance matrix - Document that YAML files are now the source of truth Addresses review comment in open-telemetry#4631
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
Is it worth adding instructions to CONTRIBUTING.md about how to update the matrix?
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This is great, is there a follow up to add a CI check for this?
oops! I had meant to add that, will do that today |
|
Out of curiosity: if thee template gets a new section and the implementation portions (C++, Java, etc) don't have such section yet, does this keep on working? |
yes |
|
@trask We are ready to merge. I don't think we should hold this PR anymore but we should remind maintainers at tomorrow's call about this change, etc. |
|
Please make sure there are no conflicts with pending PR that also change the spec compliance matrix, such as #4628 Git will not report a merge conflict, but make sure changes are not lost when translated to the new yaml file. |
|
Thanks for the feedback/review @kaylareopelle ! |
6e57784
## Changes This PR is a redo of #4628 to account for the changes made in #4631. To quote the description of #4628: > The Ruby Metrics and Logs implementations added a lot of features since this matrix was last updated. However, we're still in "Development" status, so I'm not sure if this is the appropriate time to update the matrix. Please let me know if we should wait. This also includes some changes to the traces and environment variables sections. There are a few small differences between the boxes checked in #4628 to reflect recent changes. cc @open-telemetry/ruby-maintainers --------- Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
10 participants
Part of #3976 (comment)
The goal of this PR is to yamlify the spec compliance matrix without affecting the resulting markdown file (other than whitespace differences), so that folks can be sure the yaml files are correct extraction of the current state of the markdown file.