Merged
Conversation
bryce-b
force-pushed
the
semantic-attribute-fix
branch
2 times, most recently
from
96b7dd6 to
9cfa46a
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
2 times, most recently
from
22a459b to
f81c258
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
6 times, most recently
from
213eb1d to
68b2f19
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
from
68b2f19 to
cfd0f3c
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
from
b81965d to
234a636
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
2 times, most recently
from
0609cb8 to
0b44e42
Compare
bryce-b
force-pushed
the
semantic-attribute-fix
branch
from
0b44e42 to
d1cd528
Compare
bryce-b
requested review from
ArielDemarco,
nachoBonafonte and
vvydier
as code owners
added deprecation messages to ResourceAttributes & SemanticAttributes
bryce-b
commented
Sep 4, 2025
| } | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
I added these convenience methods to allow the use of SemanticConventions without having to use rawValue everywhere. We might consider bringing this into the main framework, rather than just the tests.
nachoBonafonte
approved these changes
Sep 4, 2025
Member
|
Keeping the previous files for compatibility but annotated is a great idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the semantic attribute generation to use the new
weavertoolset.I'm not entirely sure which semconv namespaces we should target, please review and we can discuss which are unnecessary to include (e.g.: we probably don't need to include
Webengine)After conversing with the semconv group in slack, I've decided to leave the original files
OpenTelemetryApi/Trace/SemanticAttribute.swiftandOpenTelemetrySdk/Resources/ResourceAttributes.swiftfor backwards compatibility.Note that semconv are no longer organized by signal types so this original structure is obsolete.
I've opted to create a new structure under
OpenTelemetryApi/Common/SemanticConventionsThe new enums can be accessed through the class
SemanticConventionsextended by semconv namespaces, eg:SemanticConventions.Andorid.<etc>Here is an example of the documentation generated:
