Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of multiple collector config files #5960

Closed
wants to merge 0 commits into from
Closed

Document usage of multiple collector config files #5960

wants to merge 0 commits into from

Conversation

meswapnilk
Copy link
Contributor

Closes #5296

@meswapnilk meswapnilk requested a review from a team as a code owner January 17, 2025 04:52
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team January 17, 2025 04:52
@opentelemetrybot opentelemetrybot requested a review from a team January 17, 2025 04:58
tiffany76
tiffany76 requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @meswapnilk! I've made a few copy edit suggestions. Also, please see my comment about moving your addition a little higher on the page.

content/en/docs/collector/configuration.md Outdated Show resolved Hide resolved
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@meswapnilk meswapnilk force-pushed the issue-5296 branch 2 times, most recently from c51bfbc to a1a7abe Compare January 18, 2025 04:18
tiffany76
tiffany76 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@open-telemetry/collector-approvers, PTAL.

svrnm
svrnm reviewed Jan 20, 2025
View reviewed changes
content/en/docs/collector/configuration.md Outdated
You can also provide configurations using environment variables, HTTP URIs, or
YAML paths. For example:

```shell
otelcol --config=env:MY_CONFIG_IN_AN_ENVVAR --config=https://server/config.yaml
otelcol --config="yaml:exporters::debug::verbosity: normal"
```
````
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````
```

Revert that change please

svrnm
svrnm reviewed Jan 20, 2025
View reviewed changes
content/en/docs/collector/configuration.md Outdated
Comment on lines 41 to 42
````shell
otelcol --config=file:/path/to/first/file --config=file:/path/to/second/file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````shell
otelcol --config=file:/path/to/first/file --config=file:/path/to/second/file
```shell
otelcol --config=file:/path/to/first/file --config=file:/path/to/second/file
```

Use three ticks, also terminate your code block

@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team January 20, 2025 09:49
@meswapnilk meswapnilk closed this Jan 20, 2025
@meswapnilk meswapnilk deleted the issue-5296 branch January 20, 2025 09:54
@meswapnilk
Copy link
Contributor Author

@svrnm Apologies, I messed up this review a bit, I have created another PR #5989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm left review comments

@tiffany76 tiffany76 tiffany76 approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth was automatically assigned from open-telemetry/collector-approvers

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi was automatically assigned from open-telemetry/docs-es-approvers

Assignees
No one assigned
Labels
blog lang:es lang:zh registry sig:collector sig:demo sig:java sig:javascript
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of multiple collector config files is not clearly documented
3 participants
@meswapnilk @svrnm @tiffany76