-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s annotation discovery blogpost #5967
K8s annotation discovery blogpost #5967
Conversation
e8de438
to
f6215ae
Compare
FYI @open-telemetry/docs-maintainers sth is odd with the 2025 index page and I cannot find the preview page that is built. I assume it's because there is no prior blog post for 2025 and something is missing there but not sure what. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first pass! This is a really great feature I was not aware coming, so great to have a blog post.
Note: we should also think about turning some of that into documentation immediatly otherwise this gets dated and people will refer to it as docs, would you be able to provide that as well? Could be a very basic page with an example to begin with
f6215ae
to
3183ec2
Compare
3763d98
to
d6bcd8c
Compare
Thank's for reviewing @svrnm! About turning this into documentation: I linked the last paragraph to the perspective documentation of that feature in the Collector: https://github.com/open-telemetry/opentelemetry.io/pull/5967/files#diff-4fa372b70b4ce1ad702b596ad6f06decb547f6de4dd4ca979ffeee2bac298f72R182. Would we need more than this? |
I mean adding a section/page somewhere in https://opentelemetry.io/docs/collector/ |
My only concern would be that we would need to maintain that source in addition to receiver's README, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🚀 Just a couple nits/typos. with the caveats that I'm not a native English speaker, so my suggestions might be incorrect. Feel free to discard them.
854f6a1
to
f6a43c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
67993ab
to
0eb852e
Compare
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12919783314 |
IMPORTANT: (RE-)RUN
|
187d487
to
ef477e5
Compare
623fb64
to
3018504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny polishes, otherwise LGTM! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (mainly for overall structure) once @tiffany76's suggestions are addressed.
Co-authored-by: Dmitrii Anoshin <[email protected]> Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
7276b56
to
32906dd
Compare
This PR adds a blog post about the new functionality of the Opentelemetry Collector which was introduced with open-telemetry/opentelemetry-collector-contrib#34427.
With this new feature now the Collector provides support for dynamic workload discovery based on Kubernetes Pods's annotations.
Preview: https://deploy-preview-5967--opentelemetry.netlify.app/blog/2025/otel-collector-k8s-discovery/
/cc @dmitryax