-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update opentelemetry-collector-releases version to v0.140.1 #8452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update opentelemetry-collector-releases version to v0.140.1 #8452
Conversation
…ollector-releases-v0.140.1
…ollector-releases-v0.140.1
…ollector-releases-v0.140.1
|
Hi @open-telemetry/collector-approvers! Has the By checking the https://github.com/open-telemetry/opentelemetry-collector repository directly, the tag
|
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 0.140.0 than 0.140.1
|
Right, we've hit this problem before ... a few times. Visit https://github.com/open-telemetry/opentelemetry-collector-releases/releases/tag/v0.140.1, then visit each of the changelogs. You'll see that the core CL yields a 404. @tiffany76 - how did we solve this in the past? Did we wait until both releases (contrib and core) were synced on their versions? Do we have an issue open for this already? If we don't have an issue for this already we should open one. I think that the solution for this repo is to create two versions, one for the contrib and one for the core. Then we'll need to adapt the update script so that it updates only the package version that has actually be changed. |
|
Oh, I didn't pay attention the PR status. I'm glad it hasn't been merged yet. 😅 |
|
Yes, we have an outstanding issue. It's a little more complicated than In the meantime, I've just been waiting for the next release bot update where CI passes because the version numbers are uniform. 🤷 |
|
I don't think that will happen here unfortunately; see this comment on the release issue. We can't modify tags once they've been pushed in core/contrib because Go relies on them, so if the CI triggered by the tags failed, we have no choice but to up the patch version for that specific repo. So in this case, the version that was released is 0.140.0 for the core source release and prebuilt artifacts, but 0.140.1 for the contrib source release. |

Update opentelemetry-collector-releases version to
v0.140.1.See https://github.com/open-telemetry/opentelemetry-collector-releases/releases/tag/v0.140.1.