Skip to content

[adjust-pages.pl] Add upper bound version support to patch helper #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vitorvasc wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[adjust-pages.pl] Add upper bound version support to patch helper #8912

vitorvasc wants to merge 1 commit into from
+20 −8

Conversation

@vitorvasc
Copy link
Member

@vitorvasc vitorvasc commented Jan 15, 2026

  • Allows disabling patches via version constraints without removing code.
  • Add optional 4th parameter $maxVers to applyPatchOrPrintMsgIf() function
  • Patch skips when submodule version > maxVers (inclusive upper bound)
  • Backward compatible with existing 3-parameter calls

@vitorvasc vitorvasc requested a review from a team as a code owner January 15, 2026 11:43
@otelbot-docs otelbot-docs bot requested a review from a team January 15, 2026 11:43
@vitorvasc vitorvasc force-pushed the scripts_adjust-pages_add-maxvers-to-patch-helper branch from ac0fee8 to 6f43910 Compare January 15, 2026 11:44
@vitorvasc vitorvasc removed the request for review from a team January 15, 2026 11:45
@vitorvasc vitorvasc removed the sig:obi label Jan 15, 2026
tiffany76
tiffany76 approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

chalin
chalin reviewed Jan 17, 2026
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look ASAIC.

@chalin chalin marked this pull request as draft January 17, 2026 14:55
@vitorvasc vitorvasc added the CI/infra Repo CI & infrastructure label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalin chalin chalin left review comments

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees

@chalin chalin

Labels

CI/infra Repo CI & infrastructure

Projects

SIG Comms: PRs & Issues
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitorvasc @chalin @tiffany76