Skip to content

Add support for schema key aliases in query engine Parsers#1725

Merged
drewrelmas merged 12 commits intoopen-telemetry:mainfrom
drewrelmas:drewrelmas/bridge-aliases
Feb 11, 2026
Merged

Add support for schema key aliases in query engine Parsers#1725
drewrelmas merged 12 commits intoopen-telemetry:mainfrom
drewrelmas:drewrelmas/bridge-aliases

Conversation

@drewrelmas
Copy link
Copy Markdown
Contributor

@drewrelmas drewrelmas commented Jan 6, 2026

Draft PR to open discussion - The current otlp-bridge for the recordset engine uses the OpenTelemetry log data model spec for its initial schema keys (Attributes, Timestamp, ObservedTimestamp, SeverityText, etc).

However, many well-versed in the OpenTelemetry space may be more used to the snake case representation (attributes, time_unix_nano, observed_time_unix_nano, severity_text, etc) from the proto representation.

Do we have any significant risks if we plan to support both? Inspired by severity_text reference in #1722, been on the back of my mind for a while.

This is still somewhat incomplete, could need more wiring for user-provided aliases in bridge, but for the moment just doing it for known OpenTelemetry fields.

@github-actions github-actions Bot added rust Pull requests that update Rust code query-engine Query Engine / Transform related tasks query-engine-recordset Reference query engine implementation processing over a set of records labels Jan 6, 2026
@drewrelmas drewrelmas changed the title Add support for schema key aliases Add support for schema key aliases in query engine Parsers Jan 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 80.30769% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.27%. Comparing base (1f22e63) to head (0c2df01).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   86.26%   86.27%   +0.01%     
==========================================
  Files         525      525              
  Lines      165063   165273     +210     
==========================================
+ Hits       142384   142595     +211     
+ Misses      22145    22144       -1     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 88.25% <ø> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.30% <80.30%> (+0.06%) ⬆️
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 92.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread rust/experimental/query_engine/parser-abstractions/src/parser.rs Outdated
Comment thread rust/experimental/query_engine/parser-abstractions/src/parser.rs Outdated
Comment thread rust/experimental/query_engine/parser-abstractions/src/parser.rs Outdated
Comment thread rust/experimental/query_engine/engine-recordset-otlp-bridge/src/logs.rs Outdated
@drewrelmas drewrelmas marked this pull request as ready for review January 21, 2026 01:14
@drewrelmas drewrelmas requested a review from a team as a code owner January 21, 2026 01:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

This pull request has been marked as stale due to lack of recent activity. It will be closed in 30 days if no further activity occurs. If this PR is still relevant, please comment or push new commits to keep it active.

@github-actions github-actions Bot added stale Not actively pursued and removed stale Not actively pursued labels Feb 5, 2026
@drewrelmas drewrelmas force-pushed the drewrelmas/bridge-aliases branch from 66a2019 to a028eef Compare February 10, 2026 22:45
Copy link
Copy Markdown
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewrelmas drewrelmas added this pull request to the merge queue Feb 10, 2026
Merged via the queue into open-telemetry:main with commit 0d0af9a Feb 11, 2026
61 of 62 checks passed
@drewrelmas drewrelmas deleted the drewrelmas/bridge-aliases branch February 11, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query-engine Query Engine / Transform related tasks query-engine-recordset Reference query engine implementation processing over a set of records rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants