Skip to content

Conversation

@albertlockett
Copy link
Member

I'm pretty sure this is why we're seeing the OTAP -> Filter benchmark dropping the logs.

We were assuming the IDs were plain encoded in the filter processor, but if they have the transport optimized encoding (e.g., if they were received by OTAP receiver), they'd have the delta encoding which would really mess things up when we try to join the attributes to the logs.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 16, 2026
@albertlockett
Copy link
Member Author

cc @cijothomas

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.40%. Comparing base (bd62852) to head (e6fafd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1811   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         496      496           
  Lines      145393   145393           
=======================================
  Hits       122716   122716           
  Misses      22143    22143           
  Partials      534      534           
Components Coverage Δ
otap-dataflow 85.68% <ø> (ø)
query_abstraction 80.61% <ø> (ø)
query_engine 90.52% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 90.66% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertlockett
Copy link
Member Author

Leaving this as draft until we have time to confirm this fixes the integration test

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants