remove transport optimized ID encoding in filter processor #1811
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is why we're seeing the OTAP -> Filter benchmark dropping the logs.
We were assuming the IDs were plain encoded in the filter processor, but if they have the transport optimized encoding (e.g., if they were received by OTAP receiver), they'd have the delta encoding which would really mess things up when we try to join the attributes to the logs.