Draft - AzureMonitor heartbeat fix #1991
Draft
+59
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Feb 7, 2026
| if std::env::var("ARM_RESOURCE_ID").is_ok() { | ||
| "Azure".to_string() | ||
| } else { | ||
| "Non-Azure".to_string() |
Member
Author
There was a problem hiding this comment.
is "Edge" a better term? Or "Arc-Connected-Azure" if we can reliably determine that.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
- Coverage 85.78% 85.78% -0.01%
==========================================
Files 513 513
Lines 163122 163152 +30
==========================================
+ Hits 139941 139954 +13
- Misses 22647 22664 +17
Partials 534 534
🚀 New features to boost your workflow:
|
ThomsonTan
reviewed
Feb 7, 2026
| pub async fn send(&mut self) -> Result<(), Error> { | ||
| self.heartbeat_row.time = Utc::now().to_rfc3339(); | ||
| let payload = serde_json::json!([self.heartbeat_row]); | ||
| // println!("Sending heartbeat payload: {}", payload); |
ThomsonTan
reviewed
Feb 7, 2026
| heartbeat_row: HeartbeatRow { | ||
| time: Utc::now().to_rfc3339(), | ||
| version: default_heartbeat_version(), | ||
| category: "Direct Agent".to_string(), |
Contributor
There was a problem hiding this comment.
Extract category into a variable for consistency?
jmacd
approved these changes
Feb 9, 2026
Member
Author
|
Not for merge. Opened a draft to share my ideas with @gouslu who will incorporate changes where it makes sense. (It was easy for me explain what I had in my mind via a PR :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What issue does this PR close?
How are these changes tested?
Are there any user-facing changes?