Reindex implementation#2021
Merged
albertlockett merged 58 commits intoopen-telemetry:mainfrom Feb 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
+ Coverage 86.40% 86.62% +0.21%
==========================================
Files 526 527 +1
Lines 167292 168879 +1587
==========================================
+ Hits 144551 146283 +1732
+ Misses 22207 22062 -145
Partials 534 534
🚀 New features to boost your workflow:
|
Member
albertlockett
left a comment
There was a problem hiding this comment.
Looks like good progress so far! I had a few small questions/comments
jmacd
approved these changes
Feb 13, 2026
utpilla
reviewed
Feb 13, 2026
utpilla
reviewed
Feb 13, 2026
utpilla
reviewed
Feb 13, 2026
utpilla
approved these changes
Feb 13, 2026
albertlockett
approved these changes
Feb 13, 2026
Merged
via the queue into
open-telemetry:main
with commit Feb 13, 2026
75a2f71
61 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This is a reimplementation of reindex as a part of the ongoing work of #1926. This now reindexes all the required columns, has support for metrics, and has support for dictionary encoded columns.
I also was able to uncomment most of the batching tests after this change 🥳. One more to go which requires split.
Other minor changes:
allowed_payload_typesreturns payload types in the exact same order that they are stored. This is occasionally handy to have.Things deferred:
What issue does this PR close?
Part of #1926.
How are these changes tested?
I added a big unit test suite.
Are there any user-facing changes?
No.