Skip to content

[recordset_kql_processor] Logging tweaks #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewrelmas merged 1 commit into from
Feb 20, 2026
Merged

[recordset_kql_processor] Logging tweaks #2074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 46 additions & 38 deletions rust/otap-dataflow/crates/otap/src/experimental/recordset_kql_processor/processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,37 +87,45 @@ impl RecordsetKqlProcessor {
.unwrap_or_default()
.set_include_dropped_records(false)
.set_diagnostic_options(BridgeDiagnosticOptions::Callback(|d| {
let max = d
.get_diagnostics()
.iter()
.map(|v| v.get_diagnostic_level())
.max()
.unwrap_or_default();

match max {
RecordSetEngineDiagnosticLevel::Verbose => {
otap_df_telemetry::otel_debug!(
"recordset_kql_processor.query_output",
formatted_diagnostics = %d
);
}
RecordSetEngineDiagnosticLevel::Info => {
otap_df_telemetry::otel_info!(
"recordset_kql_processor.query_output",
formatted_diagnostics = %d
);
}
RecordSetEngineDiagnosticLevel::Warn => {
otap_df_telemetry::otel_warn!(
"recordset_kql_processor.query_output",
formatted_diagnostics = %d
);
}
RecordSetEngineDiagnosticLevel::Error => {
otap_df_telemetry::otel_error!(
"recordset_kql_processor.query_output",
formatted_diagnostics = %d
);
for diagnostic in d.get_diagnostics() {
let (query_line_number, query_column_number) = diagnostic
.get_expression()
.get_query_location()
.get_line_and_column_numbers();
let message = diagnostic.get_message();
match diagnostic.get_diagnostic_level() {
RecordSetEngineDiagnosticLevel::Verbose => {
otap_df_telemetry::otel_debug!(
"recordset_kql_processor.query_output",
query_line_number,
query_column_number,
message
);
}
RecordSetEngineDiagnosticLevel::Info => {
otap_df_telemetry::otel_info!(
"recordset_kql_processor.query_output",
query_line_number,
query_column_number,
message
);
}
RecordSetEngineDiagnosticLevel::Warn => {
otap_df_telemetry::otel_warn!(
"recordset_kql_processor.query_output",
query_line_number,
query_column_number,
message
);
}
RecordSetEngineDiagnosticLevel::Error => {
otap_df_telemetry::otel_error!(
"recordset_kql_processor.query_output",
query_line_number,
query_column_number,
message
);
}
}
}
}))
Expand All @@ -140,7 +148,7 @@ impl RecordsetKqlProcessor {
OtlpProtoBytes::ExportLogsRequest(bytes) => {
otap_df_telemetry::otel_debug!(
"recordset_kql_processor.processing_logs",
input_items = input_items
input_items
);
self.process_logs(bytes, signal)
}
Expand All @@ -162,8 +170,8 @@ impl RecordsetKqlProcessor {

otap_df_telemetry::otel_debug!(
"recordset_kql_processor.success",
input_items = input_items,
output_items = output_items,
input_items,
Copy link
Copy Markdown
Member

@cijothomas cijothomas Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification!

output_items,
);

let processed_data = OtapPdata::new(ctx, payload);
Expand All @@ -175,8 +183,8 @@ impl RecordsetKqlProcessor {
let message = e.to_string();
otap_df_telemetry::otel_error!(
"recordset_kql_processor.failure",
input_items = input_items,
error = message,
input_items,
message,
);

effect_handler
Expand Down Expand Up @@ -242,7 +250,7 @@ impl Processor<OtapPdata> for RecordsetKqlProcessor {
Err(e) => {
otap_df_telemetry::otel_warn!(
"recordset_kql_processor.reconfigure_error",
error = %e
message = %e
);
None
}
Expand All @@ -268,7 +276,7 @@ impl Processor<OtapPdata> for RecordsetKqlProcessor {
format!("Failed to parse updated query: {:?}", errors);
otap_df_telemetry::otel_error!(
"recordset_kql_processor.reconfigure_error",
error = message,
message,
);
}
}
Expand Down
Loading