fix: Move batch processor to 100klrps scenario and add otap-batch-otap#2395
Merged
jmacd merged 2 commits intoopen-telemetry:mainfrom Mar 23, 2026
Merged
fix: Move batch processor to 100klrps scenario and add otap-batch-otap#2395jmacd merged 2 commits intoopen-telemetry:mainfrom
jmacd merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
- Coverage 88.01% 88.00% -0.02%
==========================================
Files 582 582
Lines 204179 204179
==========================================
- Hits 179713 179688 -25
- Misses 23940 23965 +25
Partials 526 526
🚀 New features to boost your workflow:
|
Contributor
Author
|
CC: @cijothomas |
cijothomas
approved these changes
Mar 23, 2026
Member
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
(Regarding using batch processor in passthrough - I will come back on it, if needed later. They can be truly passthrough now without any processor in the middle.)
albertlockett
approved these changes
Mar 23, 2026
jmacd
approved these changes
Mar 23, 2026
Merged
via the queue into
open-telemetry:main
with commit Mar 23, 2026
e8e67bd
68 of 69 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR moves the continuous batch processor benchmarks to the 1ooklrps scenario and adds an otap-batch-otap configuration.
I think the batch processor benchmarks were mistakenly added to the "passthrough" scenario which states it's for scenarios with no processor in the middle. The dashboard also does not seem to be set up properly for these and we want to add otap-batch-otap as mentioned here: #2246 (comment)