-
Notifications
You must be signed in to change notification settings - Fork 100
Isolation of setup-protoc jobs from RUST-CI #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
66e5e74
0459f98
f2b8ca6
50925be
5b93645
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,23 +3,23 @@ | |
| #[derive(crate::otlp::Message)] | ||
| #[derive(Clone, PartialEq, ::prost::Message)] | ||
| pub struct ExportLogsServiceRequest { | ||
| #[prost(message, repeated, tag="1")] | ||
| #[prost(message, repeated, tag = "1")] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can I assume that these changes to the I assume it has been a while since someone ran and committed
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, all changes related to
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly I tried the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Locally
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd be careful about adding
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One small suggestion: it might be worth pinning the protoc version in Side note - since
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds reasonable! Is there an specific protoc version that would be preferred for CI? https://github.com/protocolbuffers/protobuf/releases
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd suggest using 34.1, that's the current stable protobuf release - https://github.com/protocolbuffers/protobuf/releases/tag/v34.1
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome, should be good to go now. Also pinned the version in |
||
| pub resource_logs: ::prost::alloc::vec::Vec<super::super::super::logs::v1::ResourceLogs>, | ||
| } | ||
| #[crate::otlp::qualified("opentelemetry.proto.collector.logs.v1.ExportLogsServiceResponse")] | ||
| #[derive(crate::otlp::Message)] | ||
| #[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)] | ||
| pub struct ExportLogsServiceResponse { | ||
| #[prost(message, optional, tag="1")] | ||
| #[prost(message, optional, tag = "1")] | ||
| pub partial_success: ::core::option::Option<ExportLogsPartialSuccess>, | ||
| } | ||
| #[crate::otlp::qualified("opentelemetry.proto.collector.logs.v1.ExportLogsPartialSuccess")] | ||
| #[derive(crate::otlp::Message)] | ||
| #[derive(Clone, PartialEq, Eq, Hash, ::prost::Message)] | ||
| pub struct ExportLogsPartialSuccess { | ||
| #[prost(int64, tag="1")] | ||
| #[prost(int64, tag = "1")] | ||
| pub rejected_log_records: i64, | ||
| #[prost(string, tag="2")] | ||
| #[prost(string, tag = "2")] | ||
| pub error_message: ::prost::alloc::string::String, | ||
| } | ||
| /// Generated client implementations. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.