Fix: move test only helpers, remove unnecessary lint suppressions#2773
Merged
jmacd merged 3 commits intoopen-telemetry:mainfrom Apr 29, 2026
Merged
Fix: move test only helpers, remove unnecessary lint suppressions#2773jmacd merged 3 commits intoopen-telemetry:mainfrom
jmacd merged 3 commits intoopen-telemetry:mainfrom
Conversation
utpilla
reviewed
Apr 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 647 647
Lines 250275 250275
==========================================
- Hits 220693 220692 -1
- Misses 29058 29059 +1
Partials 524 524
🚀 New features to boost your workflow:
|
utpilla
approved these changes
Apr 28, 2026
Merged
via the queue into
open-telemetry:main
with commit Apr 29, 2026
ff7d0ad
77 of 79 checks passed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move test only helpers, remove unnecessary lint suppressions public APIs
Change Summary
#[cfg(test)], removes unnecessary#[allow(dead_code)]What issue does this PR close?
Quick lint fixes for code hygiene
How are these changes tested?
Verified using
cargo checkandcargo testcargo check -p otap-df-channelcargo check -p otap-df-core-nodescargo test -p otap-df-core-nodes -- syslogAre there any user-facing changes?
No