Skip to content

Fix: move test only helpers, remove unnecessary lint suppressions#2773

Merged
jmacd merged 3 commits intoopen-telemetry:mainfrom
swashtek:fix/unnecessary_suppression
Apr 29, 2026
Merged

Fix: move test only helpers, remove unnecessary lint suppressions#2773
jmacd merged 3 commits intoopen-telemetry:mainfrom
swashtek:fix/unnecessary_suppression

Conversation

@swashtek
Copy link
Copy Markdown
Contributor

move test only helpers, remove unnecessary lint suppressions public APIs

Change Summary

  1. Move test only helpers behind #[cfg(test)], removes unnecessary #[allow(dead_code)]
  2. Remove unnecessary lint suppressions on public APIs

What issue does this PR close?

Quick lint fixes for code hygiene

How are these changes tested?

Verified using cargo check and cargo test

  • cargo check -p otap-df-channel
  • cargo check -p otap-df-core-nodes
  • cargo test -p otap-df-core-nodes -- syslog

Are there any user-facing changes?

No

@swashtek swashtek requested a review from a team as a code owner April 28, 2026 18:54
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.17%. Comparing base (8a0e66a) to head (a75763a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   88.18%   88.17%   -0.01%     
==========================================
  Files         647      647              
  Lines      250275   250275              
==========================================
- Hits       220693   220692       -1     
- Misses      29058    29059       +1     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 89.76% <100.00%> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.75% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.25% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@albertlockett albertlockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swashtek !

@swashtek swashtek closed this Apr 28, 2026
@swashtek swashtek reopened this Apr 28, 2026
@jmacd jmacd added this pull request to the merge queue Apr 29, 2026
Merged via the queue into open-telemetry:main with commit ff7d0ad Apr 29, 2026
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants