Make pipeline perf test a required CI check#2778
Closed
cijothomas wants to merge 1 commit intomainfrom
Closed
Conversation
- Add pipeline_perf_test job to rust-ci.yml running on ubuntu-latest - Include it in rust-required-status-check aggregator to gate merges - Simplify pipeline-perf-on-label.yaml to only run on dedicated Oracle hardware when 'pipelineperf' label is present (no more basic path since rust-ci.yml now covers that)
github-actions
Bot
added
the
ci-repo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.01%
==========================================
Files 694 694
Lines 262622 262622
==========================================
- Hits 226066 226060 -6
- Misses 36032 36038 +6
Partials 524 524
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the pipeline performance test a required check for PR merges to catch performance regressions before they land.
Changes
pipeline_perf_testjob (runs onubuntu-latest) and include it inrust-required-status-checkaggregatorpipelineperflabel is present — the basic validation path is removed sincerust-ci.ymlnow covers itMotivation
Previously, PRs could merge even when the perf test was failing. This change ensures perf regressions block the merge queue.