Skip to content

Make pipeline perf test a required CI check#2779

Merged
albertlockett merged 4 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/require-perf-test-ci
Apr 30, 2026
Merged

Make pipeline perf test a required CI check#2779
albertlockett merged 4 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/require-perf-test-ci

Conversation

@cijothomas
Copy link
Copy Markdown
Member

@cijothomas cijothomas commented Apr 29, 2026

Summary

Make the pipeline performance test a required CI check so that PRs which break the perf test are caught before merge.

Dependency: #2780 must be merged first (it fixes the currently broken perf test).

#2774 is an example of the kind of breakage this prevents — a route rename broke the perf test but the PR still merged because the perf test was not a required check.

Changes

  • rust-ci.yml: Add pipeline_perf_test job (runs on ubuntu-latest) and include it in rust-required-status-check aggregator
  • pipeline-perf-on-label.yaml: Simplify to only run on dedicated Oracle bare-metal hardware when pipelineperf label is present — the basic validation path is removed since rust-ci.yml now covers it

Motivation

The pipeline perf test has been broken by merged PRs several times because it was not a required check. This change ensures that if a PR breaks the perf test (e.g. build failures, config issues, test infrastructure breakage), it is caught before merge.

- Add pipeline_perf_test job to rust-ci.yml running on ubuntu-latest
- Include it in rust-required-status-check aggregator to gate merges
- Simplify pipeline-perf-on-label.yaml to only run on dedicated Oracle
  hardware when 'pipelineperf' label is present (no more basic path
  since rust-ci.yml now covers that)
@github-actions github-actions Bot added the ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.09%. Comparing base (7757946) to head (09e7bc5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
- Coverage   86.09%   86.09%   -0.01%     
==========================================
  Files         694      694              
  Lines      263421   263421              
==========================================
- Hits       226802   226787      -15     
- Misses      36095    36110      +15     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 87.05% <ø> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.76% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.25% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cijothomas cijothomas marked this pull request as ready for review April 29, 2026 20:33
@cijothomas cijothomas requested a review from a team as a code owner April 29, 2026 20:33
Copy link
Copy Markdown
Contributor

@JakeDern JakeDern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please 🙂

Image

@albertlockett albertlockett enabled auto-merge April 30, 2026 11:48
@albertlockett albertlockett added this pull request to the merge queue Apr 30, 2026
Merged via the queue into open-telemetry:main with commit 524b78d Apr 30, 2026
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants