Skip to content

[PerfTest] Fix shutdown hooks: use wait=false with readyz polling (#2795) #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daviddahl wants to merge 6 commits into
base: main
Choose a base branch
from
+21 −0
Open

[PerfTest] Fix shutdown hooks: use wait=false with readyz polling (#2795) #2796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f1d43c
[PerfTest] Fix shutdown hooks: use wait=false with readyz polling (#2…
daviddahl Apr 30, 2026
e6ecff8
Address review feedback from Copilot and @cijothomas
daviddahl May 1, 2026
2df2fea
fix: restore missing method: POST on shutdown hooks
daviddahl May 1, 2026
6a56b3f
simplify: use raise_for_status: false instead of polling
daviddahl May 1, 2026
4c118f4
Merge branch 'main' into fix/perf-test-shutdown-hooks-2795
daviddahl May 1, 2026
cf6d074
Merge branch 'main' into fix/perf-test-shutdown-hooks-2795
daviddahl May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...f_test/test_suites/integration/templates/test_steps/df-loadgen-steps-docker-filtered.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Stop the df-engine and wait for it to drain in-flight data to backend.
Expand All @@ -134,6 +137,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Stop the backend-service (ensures any internal processing completes).
Expand All @@ -147,6 +153,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Brief wait to ensure final metrics are visible before scraping.
Expand Down
3 changes: 3 additions & 0 deletions ..._perf_test/test_suites/integration/templates/test_steps/df-loadgen-steps-docker-otel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Stop monitoring all components.
Expand Down
9 changes: 9 additions & 0 deletions ...eline_perf_test/test_suites/integration/templates/test_steps/df-loadgen-steps-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Stop the df-engine and wait for it to drain in-flight data to backend.
Expand All @@ -136,6 +139,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Stop the backend-service (ensures any internal processing completes).
Expand All @@ -149,6 +155,9 @@ steps:
headers:
"Content-Type": "application/json"
timeout: {{drain_timeout_secs | default(60) | int + 5}} # Client timeout slightly longer than server
raise_for_status: false
on_error:
continue: true
action:
no_op: {}
# Brief wait to ensure final metrics are visible before scraping.
Expand Down
Loading