[Geneva Exporter] Encode logs using LogsDataView#2810
Merged
jmacd merged 9 commits intoopen-telemetry:mainfrom May 5, 2026
Merged
[Geneva Exporter] Encode logs using LogsDataView#2810jmacd merged 9 commits intoopen-telemetry:mainfrom
jmacd merged 9 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
+ Coverage 86.06% 86.08% +0.01%
==========================================
Files 705 705
Lines 265493 265593 +100
==========================================
+ Hits 228498 228624 +126
+ Misses 36471 36445 -26
Partials 524 524
🚀 New features to boost your workflow:
|
AaronRM
suggested changes
May 2, 2026
utpilla
reviewed
May 4, 2026
utpilla
reviewed
May 4, 2026
Member
Author
lalitb
force-pushed
the
geneva-zero-copy-log-records
branch
from
9654a83 to
6699544
Compare
1 task
utpilla
reviewed
May 4, 2026
utpilla
reviewed
May 4, 2026
utpilla
reviewed
May 4, 2026
utpilla
reviewed
May 4, 2026
Member
Author
|
@AaronRM - Can you have a look when possible - as you have requested the changes, and it is now resolved. |
ThomsonTan
reviewed
May 5, 2026
AaronRM
approved these changes
May 5, 2026
jmacd
approved these changes
May 5, 2026
| // .map_err(|e| format!("Failed to encode logs from view: {}", e))?; | ||
|
|
||
| // Fallback path: Convert OTAP Arrow → OTLP bytes | ||
| mut otap_records @ OtapArrowRecords::Logs(_) => { |
Contributor
There was a problem hiding this comment.
Today is a good day to learn new Rust syntax.
Merged
via the queue into
open-telemetry:main
with commit May 5, 2026
8b1e57d
78 of 79 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the otel-arrow Geneva exporter to encode log payloads through the shared
LogsDataViewabstraction instead of converting logs back through OTLP proto objects.Changes
OtapLogsView, the OTAP implementation ofLogsDataView.RawLogsData, the OTLP bytes implementation ofLogsDataView.geneva-uploaderencode_and_compress_logs(&view)API for both log paths.otap-df-pdata/otap-df-pdata-viewssogeneva-uploaderuses the workspace view traits.EncodedBatch::data_len()is exposed upstream.How are these changes tested?
cargo fmt --allCARGO_NET_GIT_FETCH_WITH_CLI=true cargo check -p otap-df-contrib-nodes --features "geneva-exporter otap-df-otap/crypto-ring"Are there any user-facing changes?
None.