Add try_into_with_options with empty ConversionOptions struct#2811
Merged
jmacd merged 3 commits intoopen-telemetry:mainfrom May 4, 2026
Merged
Add try_into_with_options with empty ConversionOptions struct#2811jmacd merged 3 commits intoopen-telemetry:mainfrom
jmacd merged 3 commits intoopen-telemetry:mainfrom
Conversation
…on traits Adds an empty ConversionOptions struct and TryFromWithOptions / TryIntoWithOptions traits in pdata. Converts the OtapPayload and OtapArrowRecords to OtlpProtoBytes conversions to use the new traits. Adds Consumer::with_options. The options struct is intentionally empty as a placeholder; size limits and other knobs will be threaded through in a follow-up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds default-helper methods (try_from_with_default, try_into_with_default) to TryFromWithOptions / TryIntoWithOptions, and migrates all existing TryFrom/TryInto callsites that previously used the implicit default conversion to the new with_default helpers. This is a mechanical rename that prepares for future per-callsite ConversionOptions plumbing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
rust
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
=======================================
Coverage 86.03% 86.04%
=======================================
Files 704 704
Lines 264591 264657 +66
=======================================
+ Hits 227654 227715 +61
- Misses 36413 36418 +5
Partials 524 524
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged
via the queue into
open-telemetry:main
with commit May 4, 2026
b911578
78 of 79 checks passed
AaronRM
reviewed
May 4, 2026
| let mut metrics_proto_encoder = MetricsProtoBytesEncoder::new(); | ||
| let mut traces_proto_encoder = TracesProtoBytesEncoder::new(); | ||
| let mut proto_buffer = ProtoBuffer::with_capacity(8 * 1024); | ||
| let mut proto_buffer = ProtoBuffer::default(); |
Contributor
There was a problem hiding this comment.
@jmacd Sorry didn't get my review in before merging. Is this change potentially a small perf regression since we're going from a pre-allocation via with_capacity to default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Replaces TryInto by a new TryIntoWithOptions and a default path, then mechanically converts the code.
What issue does this PR close?
Part of #2725
Split from #2792
Are there any user-facing changes?
None.