Skip to content

Round-trip OTLP-OTAP-OTLP validation framework #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 76 commits into from
Apr 24, 2025

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 17, 2025

The goal is to test the OTAP receiver logic originally contributed in otel-arrow-rust using the pdata library to build OTLP objects for readable tests.

Part of #338
Part of #353

@jmacd
Copy link
Contributor Author

jmacd commented Apr 24, 2025

Reviewers, I believe I've addressed all the feedback.

  • Structured errors throughout (using snafu because of the precedent here, I will form an opinion about it vs thiserror)
  • Convert to tokio::process::Command, remove use of threads and sync/async adapters
  • Simplify and improve readability.

@jmacd
Copy link
Contributor Author

jmacd commented Apr 24, 2025

I attempted to fix the otel-arrow-rust tests. The make otelarrowcol step needs to be run in the CI/CD workflow to build an otelarrowcol binary for the Rust tests (or we could use a docker image, etc). I think it will be best to merge this and diagnose the failures. Tests pass locally.

@jmacd
Copy link
Contributor Author

jmacd commented Apr 24, 2025

I tried to address the formatting disagreement (between prost/tonic and rustfmt), which appears to be about editions. I tried to resolve that as well, but could not (see the new rustfmt.toml file).

FYI all clippy tests pass, edition is set to 2024, and tonic/prost are set to matching versions.

@jmacd jmacd merged commit eb68ee9 into open-telemetry:main Apr 24, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants