-
Notifications
You must be signed in to change notification settings - Fork 237
Add new Blazor metrics for Net10 #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@@ -83,3 +83,28 @@ groups: | |||
stability: stable | |||
brief: ASP.NET Core exception middleware handling result | |||
examples: ["handled", "unhandled"] | |||
- id: aspnetcore.components.type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a type of a specific component, right? If I understand correctly, the goal is to stay consistent with Ms.AspMetCore.Components
namespace, but on the telemetry, in the context of specific component, it looks confusing, so suggesting
- id: aspnetcore.components.type | |
- id: aspnetcore.component.type |
OTel suggests not to use plural form in metric namespaces - https://github.com/open-telemetry/semantic-conventions/blob/1000be4d897fafbc8554b373267992e47c1b86ac/docs/general/naming.md#pluralization
|
||
This article defines semantic conventions for Blazor metrics emitted by .NET components. | ||
|
||
TODO - is this generated ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, check out https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#2-update-the-markdown-files and you can use other md files as examples, e.g.
<!-- semconv metric.aspnetcore.routing.match_attempts --> |
we don't have it yaml (yet), but we should document recommended boundaries for histograms - e.g. like here https://github.com/open-telemetry/semantic-conventions/blob/main/docs/dotnet/dotnet-http-metrics.md#metric-httpclientrequesttime_in_queue
/ cc @semconv-dotnet-approver @stevejgordon @martinjt |
@lmolkova thanks for your time and feedback, appreciated. Let's move naming discussion back the other PR to where there are the rest of the stakeholders, so we don't have to duplicate the same explanations twice. I will update this PR once we reach conclusion there. I will also add more links and explanations later. |
Changes
Adding new metrics for Blazor UI framework
Related PR
dotnet/aspnetcore#61609
Merge requirement checklist
[chore]