Revert cpu.* metrics to system.cpu.*
#2295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In open-telemetry#1873 we decided that these metrics should move back to the `system` namespace to stay consistent with similar per-device type metrics in the `system` namespace such as `disk` and `network`.
dmitryax
approved these changes
May 22, 2025
mx-psi
approved these changes
May 23, 2025
ChrsMark
approved these changes
May 23, 2025
bertysentry
approved these changes
May 23, 2025
lmolkova
reviewed
May 23, 2025
| @@ -33,29 +33,7 @@ This metric is [recommended][MetricRecommended]. | |||
|
|
|||
| | Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations | | |||
| | -------- | --------------- | ----------- | -------------- | --------- | ------ | | |||
| | `cpu.time` | Counter | `s` | Seconds each logical CPU spent on each mode |  | | | |||
|
|
|||
There was a problem hiding this comment.
could you please update md to generate correct metrics here?
There was a problem hiding this comment.
Since there are no more cpu.* metrics, I've removed this document in f5597bc
There was a problem hiding this comment.
do we have system.cpu.time metrics somewhere in markdown? It doesn't seem so
There was a problem hiding this comment.
I mean we should add system.cpu.time | utilization | frequency here https://github.com/open-telemetry/semantic-conventions/blob/main/docs/system/system-metrics.md
lmolkova
reviewed
May 23, 2025
rogercoll
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1873
Changes
In #1873 we decided that these metrics should move back to the
systemnamespace to stay consistent with similar per-device-type metrics in thesystemnamespace such asdiskandnetwork.Merge requirement checklist
[chore]