Skip to content

Rename k8s.node.allocatable.* metrics to k8s.node.*.allocatable #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaopgrassi merged 2 commits into from
Oct 28, 2025
Merged

Rename k8s.node.allocatable.* metrics to k8s.node.*.allocatable #2973

joaopgrassi merged 2 commits into from
Oct 28, 2025

Conversation

@ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 26, 2025 •
edited
Loading

Follow up from #2822 (comment).

Changes

Apply the following renames for consistency:

  • k8s.node.allocatable.cpu -> k8s.node.cpu.allocatable
  • k8s.node.allocatable.memory -> k8s.node.memory.allocatable
  • k8s.node.allocatable.ephemeral_storage -> k8s.node.ephemeral_storage.allocatable

Collector implementation PR: open-telemetry/opentelemetry-collector-contrib#42587

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@ChrsMark ChrsMark self-assigned this Oct 26, 2025
@ChrsMark ChrsMark requested review from a team as code owners October 26, 2025 12:15
This was referenced Oct 26, 2025
Open
Merged
@ChrsMark ChrsMark force-pushed the fix_k8s_allocatable_updowncounters branch from 5a1e7a7 to fc421c0 Compare October 26, 2025 12:22
@ChrsMark
fix deprecation entries
e247f27 
Signed-off-by: ChrsMark <[email protected]>
@github-project-automation github-project-automation bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Oct 28, 2025
@joaopgrassi
Copy link
Member

joaopgrassi commented Oct 28, 2025

@ChrsMark do we wait for more k8s approvers or are we good to go?

@joaopgrassi joaopgrassi moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Oct 28, 2025
@joaopgrassi joaopgrassi added this pull request to the merge queue Oct 28, 2025
Merged via the queue into open-telemetry:main with commit b081a03 Oct 28, 2025
18 checks passed
@a-thaler a-thaler mentioned this pull request Oct 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jinja2 jinja2 jinja2 approved these changes

@rogercoll rogercoll rogercoll approved these changes

+1 more reviewer

@odubajDT odubajDT odubajDT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrsMark ChrsMark

Labels

area:k8s breaking

Projects

K8s SemConv SIG
Status: Done
Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrsMark @joaopgrassi @TylerHelmuth @jinja2 @rogercoll @odubajDT