GenAI: mark sampling-relevant attributes #2994
Open
+175
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
gen-ai-sampling-relevant
branch
from
6ac16cc to
05eb438
Compare
10 tasks
lmolkova
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
gyliu513
reviewed
Nov 15, 2025
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
aabmass
approved these changes
Jan 6, 2026
wrisa
reviewed
Jan 7, 2026
wrisa
left a comment
wrisa
left a comment
There was a problem hiding this comment.
Added a couple of comments. Rest LGTM.
| it by default. Instrumentations MAY provide a way to enable | ||
| populating this attribute. | ||
|
|
||
| The following attributes can be important for making sampling decisions |
| recommended: when span kind is `CLIENT`. | ||
| sampling_relevant: true | ||
| - ref: server.port | ||
| sampling_relevant: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the following attributes sampling-relevant on all GenAI spans they appear
gen_ai.operation.namegen_ai.provider.namegen_ai.request.modelserver.addressserver.port(also add
gen_ai.provider.nameto embeddings spans - it seems it has been forgotten)