-
Notifications
You must be signed in to change notification settings - Fork 306
Rename system.memory.shared to system.memory.linux.shared #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename system.memory.shared to system.memory.linux.shared #3263
Conversation
This aligns the shared memory metric with other Linux-specific memory metrics (system.memory.linux.available and system.memory.linux.slab.usage) Fixes open-telemetry#3260
ChrsMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good based on the relevant guidance: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/groups/system/design-philosophy.md#operating-system-in-names
Left one comment about the deprecation of the replaced metric.
|
This PR aligns with the PR discussion: open-telemetry/opentelemetry-collector-contrib#45194 (comment) Should we wait for #3261 to be merged or can this PR proceed already? |
There are already semconv for other linux specific metrics under system.memory.linux.* at Given that do we need to wait for #3261 ? |
Fixes #3260
Changes
This aligns the shared memory metric with other Linux-specific memory metrics (system.memory.linux.available and system.memory.linux.slab.usage)
There is an open PR in collector-contrib in
hostmetricsreceiver(see here) to add the system metricsystem.memory.shared, and since this is a Linux specific metric, the feedback has been to update the semconv to align with other Linux specific metrics.Since this semconv has not been implemented yet, it was decided to not mark
system.memory.sharedas deprecated.Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]