Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

Fixes #3340

Changes

This removes the attribute stability exclusion on the service entity which is not relevant since entity was split. What emerged was that the criticality attribute was now conflicting. To resolve criticality is now opt-in but can be promoted at a later point it is stablised.

A changelog has been left out as the attribute is not included in any semconv release as it has just been added.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

The service entity contains development attribute as recommended

1 participant