Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .chloggen/rpc-remove-network.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
change_type: breaking
component: rpc
note: >
Remove `network.protocol.name`, `network.protocol.version`, and `network.transport`
attributes from RPC spans and metrics.
issues: [3349, 3350]
9 changes: 3 additions & 6 deletions docs/non-normative/rpc-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ TODO (latest).
| `rpc.system` → `rpc.system.name` | [#3176](https://github.com/open-telemetry/semantic-conventions/pull/3176), [#3203](https://github.com/open-telemetry/semantic-conventions/pull/3203) | See [below](#rpcsystemname-values) for changes to the values, also now marked as sampling-relevant |
| `rpc.method` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223), [#3203](https://github.com/open-telemetry/semantic-conventions/pull/3203) | Now contains fully-qualified method name (e.g., `com.example.ExampleService/exampleMethod`), also now marked as sampling-relevant |
| `rpc.service` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Removed, integrated into `rpc.method` |
| `network.transport` | [#3350](https://github.com/open-telemetry/semantic-conventions/pull/3350) | Removed |
| `network.type` | [#2857](https://github.com/open-telemetry/semantic-conventions/pull/2857) | Removed |
| `rpc.grpc.status_code` → `rpc.response.status_code` | [#2920](https://github.com/open-telemetry/semantic-conventions/pull/2920) | Changed from int to string (e.g., `0` → `"OK"`) |
| `rpc.connect_rpc.error_code` → `rpc.response.status_code` | [#2920](https://github.com/open-telemetry/semantic-conventions/pull/2920) | |
Expand All @@ -63,8 +64,6 @@ TODO (latest).
| `server.address` | [#3203](https://github.com/open-telemetry/semantic-conventions/pull/3203) | Now marked as sampling-relevant |
| `server.port` | [#3203](https://github.com/open-telemetry/semantic-conventions/pull/3203) | Now marked as sampling-relevant |
| New: `error.type` | [#2852](https://github.com/open-telemetry/semantic-conventions/pull/2852) | |
| New: `network.protocol.name` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
| New: `network.protocol.version` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
| New: `rpc.method_original` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Original method name when `rpc.method` is set to `_OTHER` |
<!-- prettier-ignore-end -->

Expand Down Expand Up @@ -109,13 +108,12 @@ Metric changes:
| `rpc.system` &rarr; `rpc.system.name` | [#3176](https://github.com/open-telemetry/semantic-conventions/pull/3176) | See [above](#rpcsystemname-values) for changes to the values |
| `rpc.method` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Now contains fully-qualified method name (e.g., `com.example.ExampleService/exampleMethod`) |
| `rpc.service` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Removed, integrated into `rpc.method` |
| `network.transport` | [#3350](https://github.com/open-telemetry/semantic-conventions/pull/3350) | Removed |
| `network.type` | [#2857](https://github.com/open-telemetry/semantic-conventions/pull/2857) | Removed |
| `server.address` | [#3197](https://github.com/open-telemetry/semantic-conventions/pull/3197) | Changed from Recommended to Opt-In |
| `server.port` | [#3197](https://github.com/open-telemetry/semantic-conventions/pull/3197) | Changed from Recommended to Opt-In |
| New: `rpc.response.status_code` | [#2920](https://github.com/open-telemetry/semantic-conventions/pull/2920) | |
| New: `error.type` | [#2852](https://github.com/open-telemetry/semantic-conventions/pull/2852) | |
| New: `network.protocol.name` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
| New: `network.protocol.version` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
<!-- prettier-ignore-end -->

References:
Expand All @@ -142,13 +140,12 @@ Metric changes:
| `rpc.system` &rarr; `rpc.system.name` | [#3176](https://github.com/open-telemetry/semantic-conventions/pull/3176) | See [above](#rpcsystemname-values) for changes to the values |
| `rpc.method` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Now contains fully-qualified method name (e.g., `com.example.ExampleService/exampleMethod`) |
| `rpc.service` | [#3223](https://github.com/open-telemetry/semantic-conventions/pull/3223) | Removed, integrated into `rpc.method` |
| `network.transport` | [#3350](https://github.com/open-telemetry/semantic-conventions/pull/3350) | Removed |
| `network.type` | [#2857](https://github.com/open-telemetry/semantic-conventions/pull/2857) | Removed |
| `server.address` | [#3197](https://github.com/open-telemetry/semantic-conventions/pull/3197) | Changed from Recommended to Required |
| `server.port` | [#3197](https://github.com/open-telemetry/semantic-conventions/pull/3197) | Changed from Recommended to Conditionally Required |
| New: `rpc.response.status_code` | [#2920](https://github.com/open-telemetry/semantic-conventions/pull/2920) | |
| New: `error.type` | [#2852](https://github.com/open-telemetry/semantic-conventions/pull/2852) | |
| New: `network.protocol.name` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
| New: `network.protocol.version` | [#2767](https://github.com/open-telemetry/semantic-conventions/pull/2767) | |
<!-- prettier-ignore-end -->

References:
Expand Down
Loading
Loading