Conversation
| the canonical name of exception that occurred, or another low-cardinality error identifier. | ||
| Instrumentations SHOULD document the list of errors they report. | ||
|
|
||
| **[2] `gen_ai.workflow.name`:** This attribute can be populated in different frameworks eg: name of the first chain in LangChain OR name of the crew in CrewAI. |
There was a problem hiding this comment.
Is workflow name unique? Would workflow id be a better pick? Thinking about the case where I can give same name to different workflows.
There was a problem hiding this comment.
Ideally workflow name should be maintained as unique. @singankit are you suggesting multiple workflow.id for same workflow.name resulting to high cardinality?
There was a problem hiding this comment.
Same things is true fora gents too. Agent Name are probably not unique but agentId should be. My suggestion is not to rely on name being unique and use workflow.id instead for metrics.
There was a problem hiding this comment.
There is no such thing as workflow id defined and realistically, there is no such notion in the libraries. workflow name should be unique within the application - we should probably add a note on this. Instrumentations will have no means to distinguish workflows with the same name
There was a problem hiding this comment.
@lmolkova Are you suggesting for users to make sure workflow name is unique within application? Scoping metric name with application name can help make it unique even if workflow name is not unique is a possible solution but again customer need to do it.
| extends: metric_attributes.gen_ai | ||
| - id: metric.gen_ai.workflow.duration | ||
| type: metric | ||
| metric_name: gen_ai.workflow.duration |
There was a problem hiding this comment.
do we need to distinguish client and server workflows? all other metrics are either client or server.
There was a problem hiding this comment.
@lmolkova workflow is an internal concept of agentic frameworks and so as per my understanding there won't be a client and server gen_ai.workflow.duration metric. I am not aware of such a thing called server workflow ? Or to future proof, we want metric name as gen_ai.client.workflow.duration ?
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
Fixes #3318
Merge requirement checklist
[chore]