Add support for filesystem locks and their metrics#3612
Add support for filesystem locks and their metrics#3612johnleslie wants to merge 12 commits intoopen-telemetry:mainfrom
Conversation
braydonk
left a comment
There was a problem hiding this comment.
Left a couple small comments re: pluralization (we usually try to make namespaces not plural kind of like units)
To get the changes generated in the docs/system/system-metrics.md add the following within the ## Filesystem metrics section (assuming the namespace rename is accepted):
### Metric: `system.filesystem.lock.count`
<!-- semconv metric.system.filesystem.lock.count -->
<!-- prettier-ignore-start -->
<!-- prettier-ignore-end -->
<!-- endsemconv -->Re-running make generate-all should have the new info show up after that.
Done |
Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>
Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
braydonk
left a comment
There was a problem hiding this comment.
LGTM, looks like it needs a make generate-all
Done |
Fixes #3611
Changes
Merge requirement checklist
[chore]Note
make generate-all && make markdown-tocare generatingregistry.file.lockdocs indocs/registry/attributes/file.mdbut not making any changes formetric.system.filesystem.locks.countinmodel/system/metrics.yaml.