Skip to content

Add support for filesystem locks and their metrics#3612

Open
johnleslie wants to merge 12 commits intoopen-telemetry:mainfrom
johnleslie:proc-locks
Open

Add support for filesystem locks and their metrics#3612
johnleslie wants to merge 12 commits intoopen-telemetry:mainfrom
johnleslie:proc-locks

Conversation

@johnleslie
Copy link
Copy Markdown
Contributor

@johnleslie johnleslie commented Apr 12, 2026

Fixes #3611

Changes

  • create registry.file.lock representing file locks and lock operations.
  • create metric.system.filesystem.locks.count reprsenting counts of these locks/operations

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • [N/A] Links to the prototypes or existing instrumentations (when adding or changing conventions)

Note

make generate-all && make markdown-toc are generating registry.file.lock docs in docs/registry/attributes/file.md but not making any changes for metric.system.filesystem.locks.count in model/system/metrics.yaml.

Copy link
Copy Markdown
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments re: pluralization (we usually try to make namespaces not plural kind of like units)

To get the changes generated in the docs/system/system-metrics.md add the following within the ## Filesystem metrics section (assuming the namespace rename is accepted):

### Metric: `system.filesystem.lock.count`

<!-- semconv metric.system.filesystem.lock.count -->
<!-- prettier-ignore-start -->

<!-- prettier-ignore-end -->
<!-- endsemconv -->

Re-running make generate-all should have the new info show up after that.

Comment thread model/file/registry.yaml Outdated
Comment thread model/system/metrics.yaml Outdated
Comment thread model/system/metrics.yaml Outdated
@johnleslie
Copy link
Copy Markdown
Contributor Author

Left a couple small comments re: pluralization (we usually try to make namespaces not plural kind of like units)

To get the changes generated in the docs/system/system-metrics.md add the following within the ## Filesystem metrics section (assuming the namespace rename is accepted):

### Metric: `system.filesystem.lock.count`

<!-- semconv metric.system.filesystem.lock.count -->
<!-- prettier-ignore-start -->

<!-- prettier-ignore-end -->
<!-- endsemconv -->

Re-running make generate-all should have the new info show up after that.

Done

johnleslie and others added 2 commits April 13, 2026 18:32
Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com>
Comment thread model/file/registry.yaml Outdated
Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
Copy link
Copy Markdown
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it needs a make generate-all

@johnleslie
Copy link
Copy Markdown
Contributor Author

LGTM, looks like it needs a make generate-all

Done

@github-project-automation github-project-automation bot moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

Add support for filesystem lock metrics

3 participants