Skip to content

fix: update release workflow for pnpm migration#1289

Merged
jsuereth merged 3 commits intomainfrom
copilot/fix-cargo-dist-workflow
Mar 13, 2026
Merged

fix: update release workflow for pnpm migration#1289
jsuereth merged 3 commits intomainfrom
copilot/fix-cargo-dist-workflow

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

The release workflow broke after switching from npm to pnpm — actions/setup-node was pointing at the non-existent ui/package-lock.json instead of ui/pnpm-lock.yaml, causing the cache step to fail and halt the job.

Additionally, cargo dist generate silently strips working-directory from injected build-setup steps, so pnpm commands were running from the repo root (no package.json there) rather than ui/.

Changes

  • .github/build-setup.yml — fix cache-dependency-path from ui/package-lock.jsonui/pnpm-lock.yaml; replace working-directory: ./ui with inline cd ui && prefix on the pnpm commands to survive cargo-dist's step injection
  • .github/workflows/release.yml — regenerated via dist generate to reflect the above changes

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

…k file

Co-authored-by: jsuereth <29006+jsuereth@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix release workflow issues with cargo-dist fix: update release workflow for pnpm migration Mar 13, 2026
Copilot AI requested a review from jsuereth March 13, 2026 20:23
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth marked this pull request as ready for review March 13, 2026 21:47
@jsuereth jsuereth requested a review from a team as a code owner March 13, 2026 21:47
@jsuereth jsuereth enabled auto-merge (squash) March 13, 2026 21:47
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.2%. Comparing base (b8ee7be) to head (1ce88c8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1289   +/-   ##
=====================================
  Coverage   81.2%   81.2%           
=====================================
  Files        111     111           
  Lines       9377    9377           
=====================================
  Hits        7623    7623           
  Misses      1754    1754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuereth jsuereth merged commit 36a07f8 into main Mar 13, 2026
46 of 49 checks passed
@jsuereth jsuereth deleted the copilot/fix-cargo-dist-workflow branch March 13, 2026 22:00
Copilot AI mentioned this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants