fix: update release workflow for pnpm migration#1289
Merged
Conversation
…k file Co-authored-by: jsuereth <29006+jsuereth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix release workflow issues with cargo-dist
fix: update release workflow for pnpm migration
Mar 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=====================================
Coverage 81.2% 81.2%
=====================================
Files 111 111
Lines 9377 9377
=====================================
Hits 7623 7623
Misses 1754 1754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow broke after switching from npm to pnpm —
actions/setup-nodewas pointing at the non-existentui/package-lock.jsoninstead ofui/pnpm-lock.yaml, causing the cache step to fail and halt the job.Additionally,
cargo dist generatesilently stripsworking-directoryfrom injected build-setup steps, so pnpm commands were running from the repo root (nopackage.jsonthere) rather thanui/.Changes
.github/build-setup.yml— fixcache-dependency-pathfromui/package-lock.json→ui/pnpm-lock.yaml; replaceworking-directory: ./uiwith inlinecd ui &&prefix on the pnpm commands to survive cargo-dist's step injection.github/workflows/release.yml— regenerated viadist generateto reflect the above changes💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.