Skip to content

BREAKING: Use schema_url to track registries consistently in lineage / provenance#1298

Merged
jsuereth merged 7 commits intoopen-telemetry:mainfrom
jsuereth:wip-use-schema-url-for-registry-id
Mar 18, 2026
Merged

BREAKING: Use schema_url to track registries consistently in lineage / provenance#1298
jsuereth merged 7 commits intoopen-telemetry:mainfrom
jsuereth:wip-use-schema-url-for-registry-id

Conversation

@jsuereth
Copy link
Contributor

This stops using a registry_id and instead uses SchemaURL to track registires. Existing registries are given a dummy SchemaURL based on their registry id, if needed.

This modifies V1 schema, as we need to make this change to start supporting V2 and the migration to V2 syntax.

I do not believe this is a significant breaking change, but there are corner cases that may need to be tweaked. Would appreciate review and consideration on other options.

@jsuereth jsuereth requested a review from a team as a code owner March 17, 2026 17:36
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.2%. Comparing base (0e454b4) to head (06b3f0e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_semconv/src/schema_url.rs 87.5% 4 Missing ⚠️
crates/weaver_resolved_schema/src/lib.rs 66.6% 1 Missing ⚠️
crates/weaver_semconv/src/provenance.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1298     +/-   ##
=======================================
- Coverage   81.3%   81.2%   -0.1%     
=======================================
  Files        111     111             
  Lines       9377    9371      -6     
=======================================
- Hits        7627    7615     -12     
- Misses      1750    1756      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- Box provenance, because we just barely eek over the minimum size
- Change SchemaUrl to avoid interior mutability (OnceLock) in favor of index/self-referencing.
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit 21c405e into open-telemetry:main Mar 18, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants