Skip to content

fix: switch gix TLS backend from native-tls to rustls#1302

Open
jmacd wants to merge 1 commit intoopen-telemetry:mainfrom
jmacd:fix/switch-gix-tls-to-rustls
Open

fix: switch gix TLS backend from native-tls to rustls#1302
jmacd wants to merge 1 commit intoopen-telemetry:mainfrom
jmacd:fix/switch-gix-tls-to-rustls

Conversation

@jmacd
Copy link

@jmacd jmacd commented Mar 19, 2026

Replace blocking-http-transport-reqwest-native-tls with blocking-http-transport-reqwest-rust-tls in weaver_common to avoid TLS conflicts for downstream consumers that use reqwest with rustls.

Remove the now-unnecessary openssl workspace dependency.

This helps with an otel-arrow PR attempting the weaver update translated into broken tests because of TLS mismatches open-telemetry/otel-arrow#2368.

Replace blocking-http-transport-reqwest-native-tls with
blocking-http-transport-reqwest-rust-tls in weaver_common to avoid TLS
conflicts for downstream consumers that use reqwest with rustls.

Remove the now-unnecessary openssl workspace dependency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jmacd jmacd requested a review from a team as a code owner March 19, 2026 00:24
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd like to provide a bit more context for the other Weaver maintainers.

The OTel Dataflow Engine (aka otel-arrow) has been using Weaver for some time to generate synthetic traffic compatible with a semantic convention registry. This is conceptually similar to weaver registry emit, but implemented as a receiver in the collector. We rely heavily on this traffic_gen receiver across nearly all our tests, including some performance benchmarks.

In addition, we have a requirement to support pluggable crypto libraries in order to handle deployments that require FIPS-compliant cryptography.

The change requested by Joshua fits within this context. From my perspective, this does not introduce any issue for Weaver, but I'd prefer to let other maintainers (@jsuereth @jerbly @lmolkova ) weigh in as well, since I'm somewhat both judge and stakeholder in this specific case.

@jerbly
Copy link
Contributor

jerbly commented Mar 19, 2026

We should do a dummy cargo dist run to check this builds correctly on all platforms.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.2%. Comparing base (21c405e) to head (8053850).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1302     +/-   ##
=======================================
- Coverage   81.2%   81.2%   -0.1%     
=======================================
  Files        111     111             
  Lines       9371    9371             
=======================================
- Hits        7617    7614      -3     
- Misses      1754    1757      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuereth
Copy link
Contributor

@jmacd We had issues at one point with our docker image and this, where the image builds, but fails to run - Just want to confirm this was tests on this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants