Skip to content

Fix CLI so it doesn't error our early when loading a resolved schema.#1304

Merged
jsuereth merged 4 commits intoopen-telemetry:mainfrom
jsuereth:wip-cli-can-load-resolved-registry
Mar 20, 2026
Merged

Fix CLI so it doesn't error our early when loading a resolved schema.#1304
jsuereth merged 4 commits intoopen-telemetry:mainfrom
jsuereth:wip-cli-can-load-resolved-registry

Conversation

@jsuereth
Copy link
Contributor

@jerbly This was the missing piece.

DId a little bit of cleanup of the Weaver API for different versions and then also added extra tests.

@jsuereth jsuereth requested a review from a team as a code owner March 19, 2026 22:52
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@462ea85). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #1304   +/-   ##
======================================
  Coverage        ?   81.2%           
======================================
  Files           ?     111           
  Lines           ?    9371           
  Branches        ?       0           
======================================
  Hits            ?    7616           
  Misses          ?    1755           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jerbly jerbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth enabled auto-merge (squash) March 20, 2026 12:38
@jsuereth jsuereth merged commit bd15e50 into open-telemetry:main Mar 20, 2026
22 checks passed
@jsuereth jsuereth deleted the wip-cli-can-load-resolved-registry branch March 20, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants