Allow multiple dependencies to be defined. #1368
Open
jsuereth wants to merge 3 commits intoopen-telemetry:mainfrom
Open
Allow multiple dependencies to be defined. #1368jsuereth wants to merge 3 commits intoopen-telemetry:mainfrom
jsuereth wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…icts between depednencies or resolve version conflicts.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
=======================================
- Coverage 81.9% 81.8% -0.1%
=======================================
Files 115 115
Lines 9850 9892 +42
=======================================
+ Hits 8069 8099 +30
- Misses 1781 1793 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
So there are a lot of shortcuts in this PR i had to fix in #1377. Debating closing this for part 2 directly. Will check in with maintainers. |
Contributor
Author
|
discussed with @jerbly - in the interest of smaller PRs, going to push this one for review first before the layer on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does NOT resolve ref conflicts between dependencies or resolve version conflicts.
This sort of fixes #1358
What this does:
schema_urlto figure out if something is a dependency.What this does NOT do
schema_urlin any dependency resolution (i.e. we COULD have a full circle and that'd be bad).refattributes or signals between dependencies with syntax - this just declares that an error and gives up.This is just starting to make progress and evaluate a smaller scope. I think there may be a more significant refactoring to solve the above, so leaving this as draft while I do some more testing.