Update semconv JSON schema for entities #731
Conversation
- Add `entity_associations` for metrics - Update `display_name` description to be more generic - Replace resource with updated entity schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=======================================
- Coverage 76.7% 76.7% -0.1%
=======================================
Files 65 65
Lines 5012 5012
=======================================
- Hits 3846 3845 -1
- Misses 1166 1167 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }, | ||
| "description": "list of identifying attributes for the entity type" | ||
| }, | ||
| "descriptive_attributes": { |
There was a problem hiding this comment.
This doesn't exist yet.
Also I'm going to be talking about this in today's tooling sync, but we may actually want descriptive to be an aspect of attribute, vs. a separate bundle, both for the ref aspect of weaver and the diff aspect.
| }, | ||
| "description": "list of descriptive attributes for the entity type" | ||
| }, | ||
| "relationships": { |
There was a problem hiding this comment.
This also doesn't exist in weaver yet, so we should hold off adding it.
| @@ -458,6 +503,11 @@ | |||
| "unit": { | |||
| "type": "string", | |||
| "description": "The unit in which the metric is measured in." | |||
| }, | |||
| "entity_associations": { | |||
There was a problem hiding this comment.
We can actually add this to Event + Span as well.
|
@jsuereth I'll keep the parts that don't exist yet in this PR and move it to draft. I'll open a new PR with the remaining changes that can be made now. Thanks for looking! |
entity_associationsfor metricsdisplay_namedescription to be more genericTo try this out in VS Code, update the .vscode/settings.json in your semconv checkout to point to
"../weaver/schemas/semconv.schema.json", assuming your weaver and semconv checkouts are in sibling directories. You may need to close and reopen the semconv window.When this is merged and a release happens a PR to semconv can be made to update the version of the JSON schema.