Skip to content

feat(lint): skip eslint from pre-commit by default#142

Closed
tagoro9 wants to merge 1 commit into
mainfrom
f/skip-eslint-on-precommit
Closed

feat(lint): skip eslint from pre-commit by default#142
tagoro9 wants to merge 1 commit into
mainfrom
f/skip-eslint-on-precommit

Conversation

@tagoro9

@tagoro9 tagoro9 commented May 22, 2025

Copy link
Copy Markdown
Member

Description

This action runs both a lint script and pre-commit. In our repos we tend to define eslint as a pre-commit hook.

This results in a redundant run of eslint in CI, making CI take double the time.

I think it makes sense to keep eslint as part of pre-commit in local environments, as that way we get a signal of errors we might be committing, but in CI disabling by default at least in this repo makes sense to speed things up.

An alternative would be to not run eslint as part of the lint script in those repos and just leverage the pre-commit run as well, which is what I think we are doing in some repos already.

Changes

  • feat(lint): skip eslint from pre-commit by default

🚀 PR created with fotingo

@github-actions

Copy link
Copy Markdown

Release notes preview

Below is a preview of the release notes if your PR gets merged.


7.1.0 (2025-05-22)

Features

  • lint: skip eslint from pre-commit by default (3ba480a)

@tagoro9 tagoro9 marked this pull request as ready for review May 22, 2025 00:34
@tagoro9 tagoro9 requested a review from a team as a code owner May 22, 2025 00:34
@tagoro9

tagoro9 commented May 22, 2025

Copy link
Copy Markdown
Member Author

Closing. I think it will be simpler to update the lint script in consumer repos

@tagoro9 tagoro9 closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant