feat(lint): skip eslint from pre-commit by default#142
Closed
tagoro9 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closing. I think it will be simpler to update the lint script in consumer repos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This action runs both a lint script and
pre-commit. In our repos we tend to defineeslintas a pre-commit hook.This results in a redundant run of eslint in CI, making CI take double the time.
I think it makes sense to keep eslint as part of pre-commit in local environments, as that way we get a signal of errors we might be committing, but in CI disabling by default at least in this repo makes sense to speed things up.
An alternative would be to not run
eslintas part of thelintscript in those repos and just leverage thepre-commitrun as well, which is what I think we are doing in some repos already.Changes
🚀 PR created with fotingo