Skip to content

feat: support docker cache, image platforms and some minor improvements#145

Merged
tagoro9 merged 6 commits into
mainfrom
f/docker-host-network
Jun 4, 2025
Merged

feat: support docker cache, image platforms and some minor improvements#145
tagoro9 merged 6 commits into
mainfrom
f/docker-host-network

Conversation

@tagoro9

@tagoro9 tagoro9 commented Jun 4, 2025

Copy link
Copy Markdown
Member

Description

THis PR updates the build docker and (pre)release actions so that we can use docker caches (just in dockerhub for now) as well as specify what platform to build the image for.

Along the way, I found a few bugs that I also fixed:

  • S3 cache for NPM modules was not supported in prerelease
  • We were passing the incorrect tags to the docker meta action
  • Added support to not post the prerelease comment

Changes

  • feat(build-docker): support cache in dockerhub, allow optional pushes and expose digest
  • feat(prerelease): support s3 caching for npm and allow to not post comment
  • feat(prerelease): allow to specify image platform and configure cache
  • docs(prerelease): update action docs
  • feat(release): support docker cache and image platform
  • fix: point build to this branch

🚀 PR created with fotingo

@tagoro9 tagoro9 requested a review from kennedy-whytech June 4, 2025 20:15
@tagoro9 tagoro9 requested a review from a team as a code owner June 4, 2025 20:15
Comment thread prerelease/action.yaml Outdated
echo "run-url=https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" >> "$GITHUB_OUTPUT"

- uses: open-turo/actions-node/build-docker@v7
- uses: open-turo/actions-node/build-docker@f/docker-host-network

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just for testing. I'll drop this commit before merging

@tagoro9 tagoro9 force-pushed the f/docker-host-network branch from e2cf973 to cbdee5c Compare June 4, 2025 20:18

@kennedy-whytech kennedy-whytech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the CI issue with the format.

@tagoro9 tagoro9 force-pushed the f/docker-host-network branch from 773b580 to c8e6c04 Compare June 4, 2025 20:41
@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

Release notes preview

Below is a preview of the release notes if your PR gets merged.


7.2.0 (2025-06-04)

Features

  • prerelease: allow to specify image platform and configure cache (8a1d0f6)
  • build-docker: support cache in dockerhub, allow optional pushes and expose digest (3415384)
  • release: support docker cache and image platform (00ff1d9)
  • prerelease: support s3 caching for npm and allow to not post comment (dc6a65a)

Bug Fixes

Miscellaneous

  • deps: update pre-commit hook pre-commit/mirrors-eslint to v9.28.0 (625bf42)

Documentation

  • prerelease: update action docs (395f7fa)

@tagoro9 tagoro9 merged commit 208ea6d into main Jun 4, 2025
2 checks passed
@tagoro9 tagoro9 deleted the f/docker-host-network branch June 4, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants