feat: add EVM testnet chains (sepolia, base-sepolia, arbitrum-sepolia, optimism-sepolia, polygon-amoy) - #213
Conversation
…, optimism-sepolia, polygon-amoy) Closes open-wallet-standard#189 Adds named testnet chain entries to the KNOWN_CHAINS registry: - sepolia (eip155:11155111) - base-sepolia (eip155:84532) - arbitrum-sepolia (eip155:421614) - optimism-sepolia (eip155:11155420) - polygon-amoy (eip155:80002) These chains were already usable via CAIP-2 ID or bare chain ID due to the generic EVM namespace fallback, but lacked friendly names. Now users can use ows wallet info --chain base-sepolia or pass base-sepolia directly to sign commands. Adds 7 unit tests covering name, CAIP-2, and bare ID parsing.
|
@ygd58 is attempting to deploy a commit to the MoonPay Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for adding the EVM testnets. The CAIP-2 ids all look correct and there's no collision with anything already in the registry, so the substance is good. Two small things before this can merge:
Once those two are in I think this is ready. Thanks. |
Address review feedback from open-wallet-standard#213: - Run cargo fmt --all to fix trailing newline - Add EVM testnet rows to Known Networks table in 07-supported-chains.md (Sepolia, Base Sepolia, Arbitrum Sepolia, Optimism Sepolia, Polygon Amoy) - Add matching shorthand aliases to the Aliases section
|
Updated in the latest commit:
|
|
Thanks, that's both points covered. The five testnet rows and the matching aliases are in |
Closes #189
Summary
Adds named testnet chain entries to the KNOWN_CHAINS registry.
Chains added
Notes
These chains were already usable via CAIP-2 ID (e.g.
eip155:84532) or bare chain ID (84532) due to the generic EVM namespace fallback inparse_chain. This PR adds friendly names so users can writebase-sepoliadirectly in CLI commands and SDK calls.Tests
Adds 7 unit tests covering name lookup, CAIP-2 lookup, and bare chain ID lookup. All 90 existing tests continue to pass.