Skip to content

Conversation

@qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Nov 11, 2025

apple swift-crypto does not pass those tests, changed to ed25519-zebra

@github-actions
Copy link

The PR correctly replaces swift-crypto with ed25519-zebra to improve Ed25519 conformance, introducing a new Rust FFI crate and updating Swift code accordingly. The changes are solid, but a minor and repetitive syntax error exists in the Swift error handling declarations.


Review Suggestions

Utils/Sources/Utils/Crypto/Ed25519.swift:16, 29, 62, 75

The function declarations use throws(Error), which is not valid Swift syntax. The typed throw (Error) should be removed, as the compiler infers the error type. For example, on line 16, public init(from seed: Data32) throws(Error) should be corrected to public init(from seed: Data32) throws. This correction should be applied to all function declarations using this invalid syntax.

xlc
xlc previously approved these changes Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.69%. Comparing base (411dfd4) to head (99b5a2b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Utils/Sources/Utils/Crypto/Ed25519.swift 92.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   81.63%   81.69%   +0.05%     
==========================================
  Files         379      380       +1     
  Lines       25903    25965      +62     
==========================================
+ Hits        21147    21212      +65     
+ Misses       4756     4753       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xlc
xlc previously approved these changes Nov 11, 2025
xlc
xlc previously approved these changes Nov 11, 2025
@qiweiii qiweiii enabled auto-merge (squash) November 11, 2025 11:32
@qiweiii qiweiii requested a review from xlc November 11, 2025 11:32
@qiweiii qiweiii merged commit c13bfac into master Nov 11, 2025
7 checks passed
@qiweiii qiweiii deleted the crypto-tests branch November 11, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants