[V2 DATA] Added A5e Marshal class #816
Open
+2,160
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Marshal class (and subclasses) from the Level Up Advanced 5e SRD (https://a5esrd.com/a5esrd) to the Open5e API (V2).
While adding this add has been a long term goal of this project, I have only opted to add one class here as a stress-test for our
CharacterClassmodel to make sure it is capable of fully expressing character class data from different sources (compare PR #808 which performs a similar task for the Tales of Valiant classes).Overall I was satisfied with how our model performed. I am uncertain how best to handle A5e's Maneuvers, which is necessary information to present to users who are building martial classes using A5e, but not actually part of the class data.
How was this tested
pytest(all passing)