Skip to content

Conversation

@kkoehn
Copy link
Contributor

@kkoehn kkoehn commented Apr 9, 2025

adds import part for #1521

also fixes #2503

@kkoehn kkoehn self-assigned this Apr 9, 2025
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (650e853) to head (694faa0).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
+ Coverage   69.37%   69.60%   +0.23%     
==========================================
  Files         211      214       +3     
  Lines        6768     6820      +52     
==========================================
+ Hits         4695     4747      +52     
  Misses       2073     2073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkoehn kkoehn force-pushed the 1521-allow-uploading-proforma-zip-files branch 4 times, most recently from 198d7b8 to be36fe3 Compare April 29, 2025 20:09
@kkoehn kkoehn marked this pull request as ready for review April 29, 2025 20:20
@kkoehn kkoehn force-pushed the 1521-allow-uploading-proforma-zip-files branch from bb8bd54 to dbe38e7 Compare May 27, 2025 21:15
Copy link
Contributor

@arkirchner arkirchner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the localization file. If there is no new line issue, please go ahead a merge the PR.

@kkoehn kkoehn force-pushed the 1521-allow-uploading-proforma-zip-files branch from dbe38e7 to 8071800 Compare May 28, 2025 21:10
@kkoehn kkoehn force-pushed the 1521-allow-uploading-proforma-zip-files branch from 8071800 to 694faa0 Compare May 28, 2025 21:23
@kkoehn kkoehn merged commit d2134c8 into main Jun 2, 2025
10 checks passed
@kkoehn kkoehn deleted the 1521-allow-uploading-proforma-zip-files branch June 2, 2025 14:46
@MrSerth
Copy link
Member

MrSerth commented Jun 2, 2025

Awesome, great to have support for uploading ProFormA files directly in CodeOcean! 🥳

I deployed the change, but noticed a few smaller issues. Would you please mind to have another check and perform a more rigid review in the future?


The headline doesn't seem to fit, does it?

Bildschirmfoto 2025-06-02 um 17 01 55

Should we add some whitespace between these buttons?

Bildschirmfoto 2025-06-02 um 17 06 34

How do we want to write ProFormA today? I see multiple options:

  • Proforma
  • ProFormA
  • ProFormAXML

Considering CodeHarbor, we even get more:

  • ProFormA-XML
  • ...

I would be in favor of deciding for a single and consistend naming scheme, that we can apply. Feel free to make proposals ;)

Bildschirmfoto 2025-06-02 um 17 04 05 Bildschirmfoto 2025-06-02 um 17 04 35

@kkoehn
Copy link
Contributor Author

kkoehn commented Jun 2, 2025

I suggest using ProFormA, since ProFormAXML or ProFormA-XML seems a bit bulky to me.

@MrSerth
Copy link
Member

MrSerth commented Jun 3, 2025

Thanks, ProFormA is my favourite, too!

I saw your new PR (thanks!) and will just commit another minor change regarding "task":

Bildschirmfoto 2025-06-03 um 16 30 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import task: Handle exercises without tests / model solution files

4 participants