Skip to content

fix: build#21

Merged
HoikanChan merged 1 commit intomasterfrom
fix/build
Mar 20, 2025
Merged

fix: build#21
HoikanChan merged 1 commit intomasterfrom
fix/build

Conversation

@HoikanChan
Copy link
Contributor

@HoikanChan HoikanChan commented Mar 20, 2025

Summary by CodeRabbit

  • New Features

    • Updated the routing interface to provide two pre-configured router components for different integration scenarios.
  • Chores

    • Enhanced the build configuration by adding new tasks to streamline routing and internationalization build processes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: d1b2d6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2025

Walkthrough

This update refactors the API for connected routers by removing the generic export of getConnectedRouter and replacing it with two dedicated constants: ConnectedRouter (initialized with 'Redux') and ConnectedHRouter (initialized with 'InulaXCompat'). The change has been applied in multiple module index files to streamline the external interface. Additionally, two new build tasks have been added to the turbo.json configuration, both of which depend on the openinula#build task.

Changes

File(s) Change Summary
packages/inula-router/src/connect-router/connectedRouter.tsx
packages/inula-router/src/connect-router/index.ts
packages/inula-router/src/router/index2.ts
Removed export of getConnectedRouter and introduced two new exports: ConnectedRouter (using 'Redux') and ConnectedHRouter (using 'InulaXCompat'), updating the module’s public API.
turbo.json Added two new tasks: "inula-router#build" and "inula-intl#build", each with a dependency on "openinula#build".

Sequence Diagram(s)

sequenceDiagram
    participant O as openinula#build
    participant R as inula-router#build
    participant I as inula-intl#build

    O->>R: Triggers build
    O->>I: Triggers build
Loading

Poem

I’m a clever rabbit in a digital burrow,
Hopping through code where changes flow.
Connected routes now come in two,
With Redux and InulaX in view.
And build tasks join the dance anew—
A carrot-filled cheer for code that grew! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5a2573 and d1b2d6e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • packages/inula-router/src/connect-router/connectedRouter.tsx (1 hunks)
  • packages/inula-router/src/connect-router/index.ts (1 hunks)
  • packages/inula-router/src/router/index2.ts (1 hunks)
  • turbo.json (1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
packages/inula-router/src/connect-router/connectedRouter.tsx (2)
packages/inula-router/src/connect-router/index.ts (2) (2)
  • ConnectedRouter (18-18)
  • ConnectedHRouter (18-18)
packages/inula-router/src/router/index2.ts (2) (2)
  • ConnectedRouter (17-17)
  • ConnectedHRouter (17-17)
🔇 Additional comments (4)
turbo.json (1)

23-33: Build configuration properly updated

The added build tasks for inula-router and inula-intl correctly establish dependencies on the openinula#build task, ensuring proper build order for packages that depend on the core library.

packages/inula-router/src/connect-router/index.ts (1)

18-18: API refactoring looks good

The export changes simplify the public API by providing pre-configured router components (ConnectedRouter and ConnectedHRouter) instead of requiring users to configure them with the factory function. This makes the API more straightforward to use.

packages/inula-router/src/router/index2.ts (1)

17-17: Export consistency maintained

The change to directly re-export the pre-configured routers from the connect-router module aligns with the API refactoring and ensures consistent router configuration throughout the codebase.

packages/inula-router/src/connect-router/connectedRouter.tsx (1)

149-150: Core API refactoring implemented correctly

The implementation now exports pre-configured router constants instead of the factory function, which simplifies the API while maintaining the same underlying functionality. Each constant is correctly initialized with its appropriate store type ('Redux' and 'InulaXCompat').

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2025

Open in Stackblitz

create-inula

npm i https://pkg.pr.new/openInula/inula/create-inula@21

openinula

npm i https://pkg.pr.new/openInula/inula/openinula@21

inula-dev-tools

npm i https://pkg.pr.new/openInula/inula/inula-dev-tools@21

inula-intl

npm i https://pkg.pr.new/openInula/inula/inula-intl@21

inula-cli

npm i https://pkg.pr.new/openInula/inula/inula-cli@21

inula-request

npm i https://pkg.pr.new/openInula/inula/inula-request@21

inula-router

npm i https://pkg.pr.new/openInula/inula/inula-router@21

commit: d1b2d6e

@HoikanChan HoikanChan merged commit 9023c4c into master Mar 20, 2025
8 checks passed
@HoikanChan HoikanChan deleted the fix/build branch June 23, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant