Fix: Added start script in package.json and fix localhost port in README(FIXES GAZ-27)#68
Merged
Merged
Conversation
Contributor
Author
|
Hello @DavidH-1 and @abhinav-1305, please review this. |
Contributor
Author
|
@DavidH-1 gentle ping |
Contributor
Author
|
Thank you, @abhinav-1305, for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem

The README documented
npm startandyarn startto run the application,but the
package.jsonhad nostartscript defined, causing new contributorsto get an error:
Missing script: "start"when trying to run the app.Additionally, the README referenced
http://localhost:3000, but Vite usesport
5173by default.Solution
Added
"start": "vite"to the scripts inpackage.jsonsonpm startworksas documented. Updated the localhost port to
5173to match Vite's default.Changes
Added
"start": "vite"script topackage.jsonUpdated localhost port from
3000to5173inREADME.mdTesting

Ran
npm startsuccessfully. Dev server started athttp://localhost:5173.