Skip to content

GAZ-42: Fix invalid Kubernetes memory quantity in ph_values.yaml#140

Open
G26karthik wants to merge 3 commits into
openMF:devfrom
G26karthik:GAZ-42/fix-mockpayment-memory-unit
Open

GAZ-42: Fix invalid Kubernetes memory quantity in ph_values.yaml#140
G26karthik wants to merge 3 commits into
openMF:devfrom
G26karthik:GAZ-42/fix-mockpayment-memory-unit

Conversation

@G26karthik

Copy link
Copy Markdown
Member

Problem

config/ph_values.yaml line 318 had an invalid Kubernetes memory
quantity suffix Miq:

memory: 192Miq

Miq is not a valid Kubernetes quantity. Valid suffixes are
Ki, Mi, Gi, etc. This can cause Helm/Kubernetes deployment
validation to silently fail or reject the resource spec when
deploying Payment Hub EE.

Fix

Changed 192Miq to 192Mi.

Related

GAZ-42 — MifosX upgrade epic (memory optimisation is an explicit
goal of this epic)
GitHub: #102

Validation

  • YAML parses successfully
  • Resource quantity scan reports no remaining invalid quantities
  • git diff --check passed
  • Confirmed not already fixed in any open PR

Checklist

  • CLA signed
  • CONTRIBUTING.md read and followed
  • Branched from dev
  • Single focused fix, no unrelated changes

@G26karthik G26karthik requested review from a team and Copilot May 10, 2026 23:40
@tdaly-mifos

Copy link
Copy Markdown
Contributor

👋 Hi @G26karthik — thank you for your pull request.

This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account.

To get unblocked:

  1. Complete the form at https://mifos.org/about-us/financial-legal/mifos-contributor-agreement
  2. Complete the CLA signing process
  3. Once verified you will be added to the approved contributors list and this PR check will be cleared

@tdaly-mifos tdaly-mifos added the cla-required CLA signature required before this PR can be merged label May 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an invalid Kubernetes resource quantity in the Payment Hub EE Helm values so deployments won’t be rejected due to an unparseable memory suffix.

Changes:

  • Corrected memory: 192Miq to the valid Kubernetes quantity memory: 192Mi in config/ph_values.yaml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@G26karthik

Copy link
Copy Markdown
Member Author

CLA has been submitted and is pending verification

@tdaly-mifos

Copy link
Copy Markdown
Contributor

👋 Hi @G26karthik — thank you for your pull request.

This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account.

To get unblocked:

  1. Complete the form at https://mifos.org/about-us/financial-legal/mifos-contributor-agreement
  2. Complete the CLA signing process
  3. Once verified you will be added to the approved contributors list and this PR check will be cleared

@tdaly-mifos tdaly-mifos removed the cla-required CLA signature required before this PR can be merged label May 11, 2026
@G26karthik

G26karthik commented May 11, 2026

Copy link
Copy Markdown
Member Author

CLA Is verified

Please look into this @DavidH-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants