-
Notifications
You must be signed in to change notification settings - Fork 826
Sync iOS configuration with project template and update Fastlane build scripts #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aryan-Baglane
wants to merge
21
commits into
openMF:dev
Choose a base branch
from
Aryan-Baglane:update-fastlane
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
99c19bd
Sync iOS configuration
Aryan-Baglane 3dce68e
Sync iOS configuration
Aryan-Baglane 7ba7604
Sync iOS configuration
Aryan-Baglane ebb9a42
Merge branch 'development' into update-fastlane
Aryan-Baglane 9120c47
Change default target branch from 'dev' to 'development'
Aryan-Baglane a9b5000
Sync iOS configuration
Aryan-Baglane 1b0bf33
Merge branch 'development' into update-fastlane
niyajali 3c8c7a2
Merge branch 'development' into update-fastlane
Aryan-Baglane 4dc3d06
Merge branch 'development' into update-fastlane
biplab1 e0e4c37
Merge branch 'development' into update-fastlane
niyajali 3d3afb6
Rename PR Checks job for clarity
Aryan-Baglane 541e36f
Merge branch 'development' into update-fastlane
Aryan-Baglane 14676c4
Sync iOS configuration
Aryan-Baglane e192127
Merge branch 'development' into update-fastlane
biplab1 6a36cd5
Merge branch 'development' into update-fastlane
Aryan-Baglane 7d3cbb9
Sync iOS configuration
Aryan-Baglane 9ad4457
Add Java version to PR check workflow
Aryan-Baglane ec47680
Merge branch 'development' into update-fastlane
Aryan-Baglane 6caa1ce
updated secrets.env file
Aryan-Baglane 163867f
Merge branch 'development' into update-fastlane
Aryan-Baglane 06db574
Merge branch 'dev' into update-fastlane
Aryan-Baglane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aryan-Baglane marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
| module FastlaneConfig | ||
| module AndroidConfig | ||
| STORE_CONFIG = { | ||
| default_store_file: "release_keystore.keystore", | ||
| default_store_password: "mifos1234", | ||
| default_key_alias: "mifos-mobile", | ||
| default_key_password: "mifos1234" | ||
| default_store_file: ProjectConfig::ANDROID[:keystore][:file], | ||
| default_store_password: ProjectConfig::ANDROID[:keystore][:password], | ||
| default_key_alias: ProjectConfig::ANDROID[:keystore][:key_alias], | ||
| default_key_password: ProjectConfig::ANDROID[:keystore][:key_password] | ||
| } | ||
|
|
||
| FIREBASE_CONFIG = { | ||
| firebase_prod_app_id: "1:728434912738:android:d853a78f14af0c381a1dbb", | ||
| firebase_demo_app_id: "1:728434912738:android:7845cce9777d9cf11a1dbb", | ||
| firebase_service_creds_file: "secrets/firebaseAppDistributionServiceCredentialsFile.json", | ||
| firebase_groups: "mifos-mobile-apps" | ||
| firebase_prod_app_id: ProjectConfig::ANDROID[:firebase][:prod_app_id], | ||
| firebase_demo_app_id: ProjectConfig::ANDROID[:firebase][:demo_app_id], | ||
| firebase_service_creds_file: ProjectConfig.firebase_credentials_file, | ||
| firebase_groups: ProjectConfig::ANDROID[:firebase][:groups] | ||
| } | ||
|
|
||
| BUILD_PATHS = { | ||
| prod_apk_path: "cmp-android/build/outputs/apk/prod/release/cmp-android-prod-release.apk", | ||
| demo_apk_path: "cmp-android/build/outputs/apk/demo/release/cmp-android-demo-release.apk", | ||
| prod_aab_path: "cmp-android/build/outputs/bundle/prodRelease/cmp-android-prod-release.aab" | ||
| prod_apk_path: ProjectConfig::ANDROID[:apk_paths][:prod], | ||
| demo_apk_path: ProjectConfig::ANDROID[:apk_paths][:demo], | ||
| prod_aab_path: ProjectConfig::ANDROID[:aab_path] | ||
| } | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| #!/usr/bin/env ruby | ||
| # ============================================================================== | ||
| # iOS Configuration Extraction Script for GitHub Actions | ||
| # ============================================================================== | ||
| # This script extracts iOS configuration from project_config.rb and outputs | ||
| # it as JSON for consumption by GitHub Actions workflows. | ||
| # | ||
| # Usage: | ||
| # ruby fastlane-config/extract_config.rb | ||
| # | ||
| # Output: | ||
| # JSON object with iOS configuration values | ||
| # ============================================================================== | ||
|
|
||
| require 'json' | ||
| require_relative 'project_config' | ||
|
|
||
| begin | ||
| # Extract iOS configuration from project_config.rb | ||
| config = { | ||
| # App-specific configuration (from IOS) | ||
| app_identifier: FastlaneConfig::ProjectConfig::IOS[:app_identifier], | ||
| firebase_app_id: FastlaneConfig::ProjectConfig::IOS[:firebase][:app_id], | ||
| firebase_groups: FastlaneConfig::ProjectConfig::IOS[:firebase][:groups], | ||
| metadata_path: FastlaneConfig::ProjectConfig::IOS[:metadata_path], | ||
| version_number: FastlaneConfig::ProjectConfig::IOS[:version_number], | ||
|
|
||
| # Shared configuration (from IOS_SHARED) | ||
| team_id: FastlaneConfig::ProjectConfig::IOS_SHARED[:team_id], | ||
| match_git_url: FastlaneConfig::ProjectConfig::IOS_SHARED[:code_signing][:match_git_url], | ||
| match_git_branch: FastlaneConfig::ProjectConfig::IOS_SHARED[:code_signing][:match_git_branch], | ||
| match_type: FastlaneConfig::ProjectConfig::IOS_SHARED[:code_signing][:match_type], | ||
|
|
||
| # Dynamically computed provisioning profiles | ||
| provisioning_profile_adhoc: FastlaneConfig::ProjectConfig::IOS_SHARED[:code_signing][:provisioning_profiles][:adhoc], | ||
| provisioning_profile_appstore: FastlaneConfig::ProjectConfig::IOS_SHARED[:code_signing][:provisioning_profiles][:appstore] | ||
| } | ||
|
|
||
| # Output as pretty-printed JSON | ||
| puts JSON.pretty_generate(config) | ||
|
|
||
| # Exit successfully | ||
| exit 0 | ||
|
|
||
| rescue => e | ||
| # Error handling | ||
| STDERR.puts "Error extracting iOS configuration:" | ||
| STDERR.puts " #{e.class}: #{e.message}" | ||
| STDERR.puts | ||
| STDERR.puts "Stack trace:" | ||
| e.backtrace.each { |line| STDERR.puts " #{line}" } | ||
| STDERR.puts | ||
| STDERR.puts "Please ensure:" | ||
| STDERR.puts " 1. fastlane-config/project_config.rb exists and is valid Ruby" | ||
| STDERR.puts " 2. Both IOS and IOS_SHARED configurations are defined" | ||
| STDERR.puts " 3. All required keys are present in the configuration" | ||
|
|
||
| # Exit with error | ||
| exit 1 | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.